2023-01-11 08:42:04

by Johan Hovold

[permalink] [raw]
Subject: [PATCH 1/2] arm64: dts: qcom: sa8450p-pmics: add missing interrupt include

Add the missing interrupt-controller include which is needed by the RTC
node.

Signed-off-by: Johan Hovold <[email protected]>
---
arch/arm64/boot/dts/qcom/sa8540p-pmics.dtsi | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/qcom/sa8540p-pmics.dtsi b/arch/arm64/boot/dts/qcom/sa8540p-pmics.dtsi
index c9b8da43b237..8c393f0bd6a8 100644
--- a/arch/arm64/boot/dts/qcom/sa8540p-pmics.dtsi
+++ b/arch/arm64/boot/dts/qcom/sa8540p-pmics.dtsi
@@ -4,6 +4,7 @@
* Copyright (c) 2022, Linaro Limited
*/

+#include <dt-bindings/interrupt-controller/irq.h>
#include <dt-bindings/spmi/spmi.h>

&spmi_bus {
--
2.38.2


2023-01-11 11:07:00

by Brian Masney

[permalink] [raw]
Subject: Re: [PATCH 1/2] arm64: dts: qcom: sa8450p-pmics: add missing interrupt include

On Wed, Jan 11, 2023 at 09:23:30AM +0100, Johan Hovold wrote:
> Add the missing interrupt-controller include which is needed by the RTC
> node.
>
> Signed-off-by: Johan Hovold <[email protected]>

Reviewed-by: Brian Masney <[email protected]>

2023-01-11 15:20:49

by Eric Chanudet

[permalink] [raw]
Subject: Re: [PATCH 1/2] arm64: dts: qcom: sa8450p-pmics: add missing interrupt include

On Wed, Jan 11, 2023 at 09:23:30AM +0100, Johan Hovold wrote:
> Add the missing interrupt-controller include which is needed by the RTC
> node.
>
> Signed-off-by: Johan Hovold <[email protected]>

Reviewed-by: Eric Chanudet <[email protected]>

Nit: sa8450p-pmics -> sa8540p-pmics in the subject. It was mistyped in
the commit renaming the file unfortunately.

--
Eric Chanudet

2023-01-11 16:36:58

by Johan Hovold

[permalink] [raw]
Subject: Re: [PATCH 1/2] arm64: dts: qcom: sa8450p-pmics: add missing interrupt include

On Wed, Jan 11, 2023 at 10:06:19AM -0500, Eric Chanudet wrote:
> On Wed, Jan 11, 2023 at 09:23:30AM +0100, Johan Hovold wrote:
> > Add the missing interrupt-controller include which is needed by the RTC
> > node.
> >
> > Signed-off-by: Johan Hovold <[email protected]>
>
> Reviewed-by: Eric Chanudet <[email protected]>
>
> Nit: sa8450p-pmics -> sa8540p-pmics in the subject. It was mistyped in
> the commit renaming the file unfortunately.

Ah, good catch. I'll resend with that fixed. Thanks.

Johan