2022-10-25 07:03:09

by Potin Lai

[permalink] [raw]
Subject: [PATCH v2 1/1] ARM: dts: aspeed-g6: add aliases for mdio nodes

Add aliases for mdio nodes so that we can use name to lookup the
bus address of Aspeed SOC.

For example:
root@bletchley:~# cat /sys/firmware/devicetree/base/aliases/mdio0
/ahb/mdio@1e650000
root@bletchley:~# cat /sys/firmware/devicetree/base/aliases/mdio1
/ahb/mdio@1e650008
root@bletchley:~# cat /sys/firmware/devicetree/base/aliases/mdio2
/ahb/mdio@1e650010
root@bletchley:~# cat /sys/firmware/devicetree/base/aliases/mdio3
/ahb/mdio@1e650018

Signed-off-by: Potin Lai <[email protected]>
---
LINK: [v1] https://lore.kernel.org/all/[email protected]/

change v1 --> v2:
* move mdio aliases to aspeed-g6.dtsi
---
arch/arm/boot/dts/aspeed-g6.dtsi | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/arch/arm/boot/dts/aspeed-g6.dtsi b/arch/arm/boot/dts/aspeed-g6.dtsi
index 0cc92874caa8..6f159ef1efbc 100644
--- a/arch/arm/boot/dts/aspeed-g6.dtsi
+++ b/arch/arm/boot/dts/aspeed-g6.dtsi
@@ -36,6 +36,10 @@ aliases {
serial4 = &uart5;
serial5 = &vuart1;
serial6 = &vuart2;
+ mdio0 = &mdio0;
+ mdio1 = &mdio1;
+ mdio2 = &mdio2;
+ mdio3 = &mdio3;
};


--
2.31.1



2023-01-03 21:43:16

by Patrick Williams

[permalink] [raw]
Subject: Re: [PATCH v2 1/1] ARM: dts: aspeed-g6: add aliases for mdio nodes

On Tue, Oct 25, 2022 at 01:50:46PM +0800, Potin Lai wrote:
> Add aliases for mdio nodes so that we can use name to lookup the
> bus address of Aspeed SOC.
>
> For example:
> root@bletchley:~# cat /sys/firmware/devicetree/base/aliases/mdio0
> /ahb/mdio@1e650000
> root@bletchley:~# cat /sys/firmware/devicetree/base/aliases/mdio1
> /ahb/mdio@1e650008
> root@bletchley:~# cat /sys/firmware/devicetree/base/aliases/mdio2
> /ahb/mdio@1e650010
> root@bletchley:~# cat /sys/firmware/devicetree/base/aliases/mdio3
> /ahb/mdio@1e650018
>
> Signed-off-by: Potin Lai <[email protected]>
> ---
> LINK: [v1] https://lore.kernel.org/all/[email protected]/
>
> change v1 --> v2:
> * move mdio aliases to aspeed-g6.dtsi
> ---
> arch/arm/boot/dts/aspeed-g6.dtsi | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm/boot/dts/aspeed-g6.dtsi b/arch/arm/boot/dts/aspeed-g6.dtsi
> index 0cc92874caa8..6f159ef1efbc 100644
> --- a/arch/arm/boot/dts/aspeed-g6.dtsi
> +++ b/arch/arm/boot/dts/aspeed-g6.dtsi
> @@ -36,6 +36,10 @@ aliases {
> serial4 = &uart5;
> serial5 = &vuart1;
> serial6 = &vuart2;
> + mdio0 = &mdio0;
> + mdio1 = &mdio1;
> + mdio2 = &mdio2;
> + mdio3 = &mdio3;
> };
>
>
> --
> 2.31.1
>

Reviewed-by: Patrick Williams <[email protected]>

--
Patrick Williams

Attachments:
(No filename) (1.35 kB)
 signature.asc (849.00 B)
 Download all attachments

2023-01-18 03:28:46

by Joel Stanley

[permalink] [raw]
Subject: Re: [PATCH v2 1/1] ARM: dts: aspeed-g6: add aliases for mdio nodes

On Tue, 25 Oct 2022 at 05:52, Potin Lai <[email protected]> wrote:
>
> Add aliases for mdio nodes so that we can use name to lookup the
> bus address of Aspeed SOC.
>
> For example:
> root@bletchley:~# cat /sys/firmware/devicetree/base/aliases/mdio0
> /ahb/mdio@1e650000
> root@bletchley:~# cat /sys/firmware/devicetree/base/aliases/mdio1
> /ahb/mdio@1e650008
> root@bletchley:~# cat /sys/firmware/devicetree/base/aliases/mdio2
> /ahb/mdio@1e650010
> root@bletchley:~# cat /sys/firmware/devicetree/base/aliases/mdio3
> /ahb/mdio@1e650018
>
> Signed-off-by: Potin Lai <[email protected]>

Thanks, that's better I think.

Reviewed-by: Joel Stanley <[email protected]>


> ---
> LINK: [v1] https://lore.kernel.org/all/[email protected]/
>
> change v1 --> v2:
> * move mdio aliases to aspeed-g6.dtsi
> ---
> arch/arm/boot/dts/aspeed-g6.dtsi | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm/boot/dts/aspeed-g6.dtsi b/arch/arm/boot/dts/aspeed-g6.dtsi
> index 0cc92874caa8..6f159ef1efbc 100644
> --- a/arch/arm/boot/dts/aspeed-g6.dtsi
> +++ b/arch/arm/boot/dts/aspeed-g6.dtsi
> @@ -36,6 +36,10 @@ aliases {
> serial4 = &uart5;
> serial5 = &vuart1;
> serial6 = &vuart2;
> + mdio0 = &mdio0;
> + mdio1 = &mdio1;
> + mdio2 = &mdio2;
> + mdio3 = &mdio3;
> };
>
>
> --
> 2.31.1
>