2023-01-02 19:54:46

by Andy Shevchenko

Subject: [PATCH v1 1/1] thunderbolt: Refactor tb_acpi_add_link()

Convert while loop into do-while with only a single call to
acpi_get_first_physical_node(). No functional change intended.

Signed-off-by: Andy Shevchenko <[email protected]>
---
drivers/thunderbolt/acpi.c | 13 +++++--------
1 file changed, 5 insertions(+), 8 deletions(-)

diff --git a/drivers/thunderbolt/acpi.c b/drivers/thunderbolt/acpi.c
index 317e4f5fdb97..628225deb8fe 100644
--- a/drivers/thunderbolt/acpi.c
+++ b/drivers/thunderbolt/acpi.c
@@ -36,16 +36,13 @@ static acpi_status tb_acpi_add_link(acpi_handle handle, u32 level, void *data,
* We need to do this because the xHCI driver might not yet be
* bound so the USB3 SuperSpeed ports are not yet created.
*/
- dev = acpi_get_first_physical_node(adev);
- while (!dev) {
- adev = acpi_dev_parent(adev);
- if (!adev)
- break;
+ do {
dev = acpi_get_first_physical_node(adev);
- }
+ if (dev)
+ break;

- if (!dev)
- goto out_put;
+ adev = acpi_dev_parent(adev);
+ } while (adev);

/*
* Check that the device is PCIe. This is because USB3
--
2.35.1

2023-01-04 08:22:24

by Mika Westerberg

Subject: Re: [PATCH v1 1/1] thunderbolt: Refactor tb_acpi_add_link()

On Mon, Jan 02, 2023 at 09:24:04PM +0200, Andy Shevchenko wrote:
> Convert while loop into do-while with only a single call to
> acpi_get_first_physical_node(). No functional change intended.
>
> Signed-off-by: Andy Shevchenko <[email protected]>

Applied, thanks!