2023-01-07 20:29:47

by Deepak R Varma

[permalink] [raw]
Subject: Re: [PATCH] soc/tegra: cbb: Remove redundant error logging

On Thu, Dec 22, 2022 at 08:54:45PM +0530, Deepak R Varma wrote:
> A call to platform_get_irq() already prints an error on failure within
> its own implementation. So printing another error based on its return
> value in the caller is redundant and should be removed. The clean up
> also makes if condition block braces unnecessary. Remove that as well.
>
> Issue identified using platform_get_irq.cocci coccinelle semantic patch.
>
> Signed-off-by: Deepak R Varma <[email protected]>
> ---

Hello,
Requesting a review and feedback on this patch proposal?

Thank you,
./drv