2023-01-08 13:43:54

by Alviro Iskandar Setiawan

[permalink] [raw]
Subject: Re: [PATCH v2 0/4] nolibc signal handling support

On Sun, Jan 8, 2023 at 8:10 PM Ammar Faizi wrote:
> 3) More selftests.
>
> This series also adds selftests for:
> - fork(2)
> - sigaction(2)
> - signal(2)
[...]
> Ammar Faizi (4):
> nolibc/sys: Implement `sigaction(2)` function
> nolibc/sys: Implement `signal(2)` function
> selftests/nolibc: Add `fork(2)` selftest
> selftests/nolibc: Add `sigaction(2)` selftest

The signal() self test is missing?
btw, it's too crowded here, let's create a new thread for this if you
ever send another version


2023-01-08 13:58:57

by Ammar Faizi

[permalink] [raw]
Subject: Re: [PATCH v2 0/4] nolibc signal handling support

On Sun, Jan 08, 2023 at 08:28:33PM +0700, Alviro Iskandar Setiawan wrote:
> The signal() self test is missing?

Ugh, yes. I didn't send the signal() selftest. Will do.

> btw, it's too crowded here, let's create a new thread for this if you
> ever send another version

I'll resend both series. Please ignore these versions...

--
Ammar Faizi

2023-01-08 13:59:13

by Ammar Faizi

[permalink] [raw]
Subject: Re: [PATCH v2 0/4] nolibc signal handling support

On Sun, Jan 08, 2023 at 08:31:37PM +0700, Ammar Faizi wrote:
> On Sun, Jan 08, 2023 at 08:28:33PM +0700, Alviro Iskandar Setiawan wrote:
> > The signal() self test is missing?
>
> Ugh, yes. I didn't send the signal() selftest. Will do.

Bah, it turned out I squashed the signal() test into "selftests/nolibc:
Add `sigaction(2)` selftes" patch. It was unintentional. Will split it
properly in v3.

--
Ammar Faizi