2023-01-06 02:43:18

by Jiapeng Chong

[permalink] [raw]
Subject: [PATCH] ASoC: amd: ps: Make acp63_fill_platform_dev_info static

This symbol is not used outside of pci-ps.c, so marks it static.

sound/soc/amd/ps/pci-ps.c:170:6: warning: no previous prototype for ‘acp63_fill_platform_dev_info’.

Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3640
Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
sound/soc/amd/ps/pci-ps.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/sound/soc/amd/ps/pci-ps.c b/sound/soc/amd/ps/pci-ps.c
index 401cfd0036be..570736e1b5e8 100644
--- a/sound/soc/amd/ps/pci-ps.c
+++ b/sound/soc/amd/ps/pci-ps.c
@@ -167,10 +167,10 @@ static void get_acp63_device_config(u32 config, struct pci_dev *pci,
}
}

-void acp63_fill_platform_dev_info(struct platform_device_info *pdevinfo, struct device *parent,
- struct fwnode_handle *fw_node, char *name, unsigned int id,
- const struct resource *res, unsigned int num_res,
- const void *data, size_t size_data)
+static void acp63_fill_platform_dev_info(struct platform_device_info *pdevinfo,
+ struct device *parent, struct fwnode_handle *fw_node,
+ char *name, unsigned int id, const struct resource *res,
+ unsigned int num_res, const void *data, size_t size_data)
{
pdevinfo->name = name;
pdevinfo->id = id;
--
2.20.1.7.g153144c


2023-01-23 13:31:00

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH] ASoC: amd: ps: Make acp63_fill_platform_dev_info static

On Fri, Jan 06, 2023 at 10:31:16AM +0800, Jiapeng Chong wrote:
> This symbol is not used outside of pci-ps.c, so marks it static.
>
> sound/soc/amd/ps/pci-ps.c:170:6: warning: no previous prototype for ‘acp63_fill_platform_dev_info’.

This doesn't apply against current code, please check and resend.


Attachments:
(No filename) (306.00 B)
signature.asc (488.00 B)
Download all attachments