2023-01-11 12:10:21

by Greg Kroah-Hartman

[permalink] [raw]
Subject: [PATCH v2 10/16] drivers: hv: move device_to_hv_device to use container_of_const()

The driver core is changing to pass some pointers as const, so move
device_to_hv_device() to use container_of_const() to handle this change.

device_to_hv_device() now properly keeps the const-ness of the pointer
passed into it, while as before it could be lost.

Cc: "K. Y. Srinivasan" <[email protected]>
Cc: Haiyang Zhang <[email protected]>
Cc: Wei Liu <[email protected]>
Cc: Dexuan Cui <[email protected]>
Cc: [email protected]
Cc: [email protected]
Signed-off-by: Greg Kroah-Hartman <[email protected]>
---
include/linux/hyperv.h | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/include/linux/hyperv.h b/include/linux/hyperv.h
index 85f7c5a63aa6..8430e27f3c3f 100644
--- a/include/linux/hyperv.h
+++ b/include/linux/hyperv.h
@@ -1309,10 +1309,7 @@ struct hv_device {
};


-static inline struct hv_device *device_to_hv_device(struct device *d)
-{
- return container_of(d, struct hv_device, device);
-}
+#define device_to_hv_device(d) container_of_const(d, struct hv_device, device)

static inline struct hv_driver *drv_to_hv_drv(struct device_driver *d)
{
--
2.39.0


2023-01-12 15:58:51

by Wei Liu

[permalink] [raw]
Subject: Re: [PATCH v2 10/16] drivers: hv: move device_to_hv_device to use container_of_const()

On Wed, Jan 11, 2023 at 12:30:12PM +0100, Greg Kroah-Hartman wrote:
> The driver core is changing to pass some pointers as const, so move
> device_to_hv_device() to use container_of_const() to handle this change.
>
> device_to_hv_device() now properly keeps the const-ness of the pointer
> passed into it, while as before it could be lost.
>
> Cc: "K. Y. Srinivasan" <[email protected]>
> Cc: Haiyang Zhang <[email protected]>
> Cc: Wei Liu <[email protected]>
> Cc: Dexuan Cui <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> Signed-off-by: Greg Kroah-Hartman <[email protected]>

Acked-by: Wei Liu <[email protected]>