2023-01-13 07:16:15

by Randy Dunlap

[permalink] [raw]
Subject: [PATCH] backlight: sky81452: fix sky81452_bl_platform_data kernel-doc

Correct the struct name and add a short struct description to fix the
kernel-doc notation.

Prevents this kernel-doc warning:
drivers/video/backlight/sky81452-backlight.c:64: warning: expecting prototype for struct sky81452_platform_data. Prototype was for struct sky81452_bl_platform_data instead

Signed-off-by: Randy Dunlap <[email protected]>
Cc: Lee Jones <[email protected]>
Cc: Daniel Thompson <[email protected]>
Cc: Jingoo Han <[email protected]>
Cc: Helge Deller <[email protected]>
Cc: [email protected]
Cc: [email protected]
---
drivers/video/backlight/sky81452-backlight.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff -- a/drivers/video/backlight/sky81452-backlight.c b/drivers/video/backlight/sky81452-backlight.c
--- a/drivers/video/backlight/sky81452-backlight.c
+++ b/drivers/video/backlight/sky81452-backlight.c
@@ -41,7 +41,7 @@
#define SKY81452_MAX_BRIGHTNESS (SKY81452_CS + 1)

/**
- * struct sky81452_platform_data
+ * struct sky81452_bl_platform_data - backlight platform data
* @name: backlight driver name.
* If it is not defined, default name is lcd-backlight.
* @gpiod_enable:GPIO descriptor which control EN pin


2023-01-13 17:05:27

by Daniel Thompson

[permalink] [raw]
Subject: Re: [PATCH] backlight: sky81452: fix sky81452_bl_platform_data kernel-doc

On Thu, Jan 12, 2023 at 10:41:18PM -0800, Randy Dunlap wrote:
> Correct the struct name and add a short struct description to fix the
> kernel-doc notation.
>
> Prevents this kernel-doc warning:
> drivers/video/backlight/sky81452-backlight.c:64: warning: expecting prototype for struct sky81452_platform_data. Prototype was for struct sky81452_bl_platform_data instead
>
> Signed-off-by: Randy Dunlap <[email protected]>
> Cc: Lee Jones <[email protected]>
> Cc: Daniel Thompson <[email protected]>
> Cc: Jingoo Han <[email protected]>
> Cc: Helge Deller <[email protected]>
> Cc: [email protected]
> Cc: [email protected]

Reviewed-by: Daniel Thompson <[email protected]>


Daniel.

2023-01-19 15:08:42

by Lee Jones

[permalink] [raw]
Subject: Re: [PATCH] backlight: sky81452: fix sky81452_bl_platform_data kernel-doc

On Thu, 12 Jan 2023, Randy Dunlap wrote:

> Correct the struct name and add a short struct description to fix the
> kernel-doc notation.
>
> Prevents this kernel-doc warning:
> drivers/video/backlight/sky81452-backlight.c:64: warning: expecting prototype for struct sky81452_platform_data. Prototype was for struct sky81452_bl_platform_data instead
>
> Signed-off-by: Randy Dunlap <[email protected]>
> Cc: Lee Jones <[email protected]>
> Cc: Daniel Thompson <[email protected]>
> Cc: Jingoo Han <[email protected]>
> Cc: Helge Deller <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> ---
> drivers/video/backlight/sky81452-backlight.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks

--
Lee Jones [李琼斯]