2023-01-14 15:21:06

by Christophe JAILLET

Subject: [PATCH] s390/ipl: Use kstrtobool() instead of strtobool() (second step)

strtobool() is the same as kstrtobool().
However, the latter is more used within the kernel.

In order to remove strtobool() and slightly simplify kstrtox.h, switch to
the other function name.

Signed-off-by: Christophe JAILLET <[email protected]>
---
This patch is similar to the serie ([1]) that tries to axed all usages
of strtobool().
Most of the patches have been merged in -next.

Commit d9b25bdf57e4 ("s390/ipl: Use kstrtobool() instead of strtobool()")
already fixed this file, but a new usage has been introduce by commit
87fd22e0ae92 ("s390/ipl: add eckd support").

This patch has been cross-compiled with make.cross.

[1]: https://lore.kernel.org/all/[email protected]/
---
arch/s390/kernel/ipl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/s390/kernel/ipl.c b/arch/s390/kernel/ipl.c
index fbd646dbf440..5547223acce0 100644
--- a/arch/s390/kernel/ipl.c
+++ b/arch/s390/kernel/ipl.c
@@ -1194,7 +1194,7 @@ static ssize_t reipl_eckd_clear_store(struct kobject *kobj,
struct kobj_attribute *attr,
const char *buf, size_t len)
{
- if (strtobool(buf, &reipl_eckd_clear) < 0)
+ if (kstrtobool(buf, &reipl_eckd_clear) < 0)
return -EINVAL;
return len;
}
--
2.34.1

2023-01-15 20:54:38

by Heiko Carstens

Subject: Re: [PATCH] s390/ipl: Use kstrtobool() instead of strtobool() (second step)

On Sat, Jan 14, 2023 at 04:08:22PM +0100, Christophe JAILLET wrote:
> strtobool() is the same as kstrtobool().
> However, the latter is more used within the kernel.
>
> In order to remove strtobool() and slightly simplify kstrtox.h, switch to
> the other function name.
>
> Signed-off-by: Christophe JAILLET <[email protected]>
> ---
> This patch is similar to the serie ([1]) that tries to axed all usages
> of strtobool().
> Most of the patches have been merged in -next.
>
> Commit d9b25bdf57e4 ("s390/ipl: Use kstrtobool() instead of strtobool()")
> already fixed this file, but a new usage has been introduce by commit
> 87fd22e0ae92 ("s390/ipl: add eckd support").
>
> This patch has been cross-compiled with make.cross.
>
> [1]: https://lore.kernel.org/all/[email protected]/
> ---
> arch/s390/kernel/ipl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks!