2023-01-18 05:08:32

by Thomas Weißschuh

[permalink] [raw]

Subject: [PATCH v3 2/2] kheaders: use standard naming for the temporary directory

---

If the kheaders archive generation is interrupted then this directory
may be left on disk and not ignored by git.
By using the standard naming schema for temporary files and directories
the default .gitignore and "make clean" rules will apply.

Suggested-by: Nicolas Schier <[email protected]>
Suggested-by: Masahiro Yamada <[email protected]>
Signed-off-by: Thomas Weißschuh <[email protected]>
---
kernel/gen_kheaders.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/gen_kheaders.sh b/kernel/gen_kheaders.sh
index 473036b43c83..b477b763f262 100755
--- a/kernel/gen_kheaders.sh
+++ b/kernel/gen_kheaders.sh
@@ -7,7 +7,7 @@ set -e
sfile="$(readlink -f "$0")"
outdir="$(pwd)"
tarfile=$1
-cpio_dir=$outdir/$tarfile.tmp
+cpio_dir=$outdir/${tarfile%/*}/.tmp_cpio_dir

dir_list="
include/

--
2.39.1

2023-01-18 09:55:50

by Nicolas Schier

[permalink] [raw]

Subject: Re: [PATCH v3 2/2] kheaders: use standard naming for the temporary directory

---

On Wed 18 Jan 2023 05:05:35 GMT, Thomas Wei?schuh wrote:
> If the kheaders archive generation is interrupted then this directory
> may be left on disk and not ignored by git.
> By using the standard naming schema for temporary files and directories
> the default .gitignore and "make clean" rules will apply.
>
> Suggested-by: Nicolas Schier <[email protected]>
> Suggested-by: Masahiro Yamada <[email protected]>
> Signed-off-by: Thomas Wei?schuh <[email protected]>
> ---
> kernel/gen_kheaders.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/gen_kheaders.sh b/kernel/gen_kheaders.sh
> index 473036b43c83..b477b763f262 100755
> --- a/kernel/gen_kheaders.sh
> +++ b/kernel/gen_kheaders.sh
> @@ -7,7 +7,7 @@ set -e
> sfile="$(readlink -f "$0")"
> outdir="$(pwd)"
> tarfile=$1
> -cpio_dir=$outdir/$tarfile.tmp
> +cpio_dir=$outdir/${tarfile%/*}/.tmp_cpio_dir
>
> dir_list="
> include/
>
> --
> 2.39.1

Thanks!

Reviewed-by: Nicolas Schier <[email protected]>
Tested-by: Nicolas Schier <[email protected]>

---

Attachments:

(No filename) (1.06 kB)
signature.asc (849.00 B)
Download all attachments