2023-01-26 15:39:19

by Hans de Goede

Subject: [PATCH v2 resend 1/3] mfd: intel_soc_pmic_chtwc: Add Lenovo Yoga Tab 3 X90F to intel_cht_wc_models

The drivers for various CHT Whiskey Cove PMIC child-devices need to know
the model, since they have model specific behavior. The DMI match table
for this is shared between the child-device-drivers inside the MFD driver.

Add the Lenovo Yoga Tab 3 X90F, which is a previously unknown tablet
model with a CHT Whiskey Cove PMIC, to the intel_cht_wc_models enum and
to the DMI match table.

Signed-off-by: Hans de Goede <[email protected]>
---
drivers/mfd/intel_soc_pmic_chtwc.c | 8 ++++++++
include/linux/mfd/intel_soc_pmic.h | 1 +
2 files changed, 9 insertions(+)

diff --git a/drivers/mfd/intel_soc_pmic_chtwc.c b/drivers/mfd/intel_soc_pmic_chtwc.c
index 9216f0d34206..d53dae255490 100644
--- a/drivers/mfd/intel_soc_pmic_chtwc.c
+++ b/drivers/mfd/intel_soc_pmic_chtwc.c
@@ -165,6 +165,14 @@ static const struct dmi_system_id cht_wc_model_dmi_ids[] = {
/* Non exact match to match all versions */
DMI_MATCH(DMI_PRODUCT_NAME, "Lenovo YB1-X9"),
},
+ }, {
+ /* Lenovo Yoga Tab 3 Pro YT3-X90F */
+ .driver_data = (void *)(long)INTEL_CHT_WC_LENOVO_YT3_X90,
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "Intel Corporation"),
+ DMI_MATCH(DMI_PRODUCT_NAME, "CHERRYVIEW D1 PLATFORM"),
+ DMI_MATCH(DMI_PRODUCT_VERSION, "Blade3-10A-001"),
+ },
},
{ }
};
diff --git a/include/linux/mfd/intel_soc_pmic.h b/include/linux/mfd/intel_soc_pmic.h
index 945bde1fe55c..9ba2c1a8d836 100644
--- a/include/linux/mfd/intel_soc_pmic.h
+++ b/include/linux/mfd/intel_soc_pmic.h
@@ -18,6 +18,7 @@ enum intel_cht_wc_models {
INTEL_CHT_WC_GPD_WIN_POCKET,
INTEL_CHT_WC_XIAOMI_MIPAD2,
INTEL_CHT_WC_LENOVO_YOGABOOK1,
+ INTEL_CHT_WC_LENOVO_YT3_X90,
};

/**
--
2.39.0

2023-02-04 13:04:57

by Lee Jones

Subject: Re: [PATCH v2 resend 1/3] mfd: intel_soc_pmic_chtwc: Add Lenovo Yoga Tab 3 X90F to intel_cht_wc_models

On Thu, 26 Jan 2023, Hans de Goede wrote:

> The drivers for various CHT Whiskey Cove PMIC child-devices need to know
> the model, since they have model specific behavior. The DMI match table
> for this is shared between the child-device-drivers inside the MFD driver.
>
> Add the Lenovo Yoga Tab 3 X90F, which is a previously unknown tablet
> model with a CHT Whiskey Cove PMIC, to the intel_cht_wc_models enum and
> to the DMI match table.
>
> Signed-off-by: Hans de Goede <[email protected]>
> ---
> drivers/mfd/intel_soc_pmic_chtwc.c | 8 ++++++++
> include/linux/mfd/intel_soc_pmic.h | 1 +
> 2 files changed, 9 insertions(+)

Applied, thanks

--
Lee Jones [李琼斯]