2023-02-04 03:50:50

by Guru Mehar Rachaputi

Subject: [PATCH] staging: vt6655: Add braces to macro parameter 'iobase'

This patch is to fix checkpatch warning: "Macro argument 'iobase' may be better
as '(iobase)' to avoid precedence issues.

Signed-off-by: Guru Mehar Rachaputi <[email protected]>
---
drivers/staging/vt6655/mac.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/vt6655/mac.h b/drivers/staging/vt6655/mac.h
index acf931c3f5fd..a33af2852227 100644
--- a/drivers/staging/vt6655/mac.h
+++ b/drivers/staging/vt6655/mac.h
@@ -537,9 +537,9 @@

/*--------------------- Export Macros ------------------------------*/

-#define VT6655_MAC_SELECT_PAGE0(iobase) iowrite8(0, iobase + MAC_REG_PAGE1SEL)
+#define VT6655_MAC_SELECT_PAGE0(iobase) iowrite8(0, (iobase) + MAC_REG_PAGE1SEL)

-#define VT6655_MAC_SELECT_PAGE1(iobase) iowrite8(1, iobase + MAC_REG_PAGE1SEL)
+#define VT6655_MAC_SELECT_PAGE1(iobase) iowrite8(1, (iobase) + MAC_REG_PAGE1SEL)

#define MAKEWORD(lb, hb) \
((unsigned short)(((unsigned char)(lb)) | (((unsigned short)((unsigned char)(hb))) << 8)))
--
2.34.1


--
Thanks & Regards,
Guru

2023-02-04 07:55:23

by Greg Kroah-Hartman

Subject: Re: [PATCH] staging: vt6655: Add braces to macro parameter 'iobase'

On Sat, Feb 04, 2023 at 04:50:41AM +0100, Guru Mehar Rachaputi wrote:
> This patch is to fix checkpatch warning: "Macro argument 'iobase' may be better
> as '(iobase)' to avoid precedence issues.
>
> Signed-off-by: Guru Mehar Rachaputi <[email protected]>
> ---
> drivers/staging/vt6655/mac.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/vt6655/mac.h b/drivers/staging/vt6655/mac.h
> index acf931c3f5fd..a33af2852227 100644
> --- a/drivers/staging/vt6655/mac.h
> +++ b/drivers/staging/vt6655/mac.h
> @@ -537,9 +537,9 @@
>
> /*--------------------- Export Macros ------------------------------*/
>
> -#define VT6655_MAC_SELECT_PAGE0(iobase) iowrite8(0, iobase + MAC_REG_PAGE1SEL)
> +#define VT6655_MAC_SELECT_PAGE0(iobase) iowrite8(0, (iobase) + MAC_REG_PAGE1SEL)

This change really doesn't make much sense, right? How about turning
these into an inline function instead? That would be the correct thing
to do overall, right?

thanks,

greg k-h

2023-02-05 00:14:20

by Guru Mehar Rachaputi

Subject: Re: [PATCH] staging: vt6655: Add braces to macro parameter 'iobase'

On Sat, Feb 04, 2023 at 08:55:09AM +0100, Greg Kroah-Hartman wrote:
> On Sat, Feb 04, 2023 at 04:50:41AM +0100, Guru Mehar Rachaputi wrote:
> > This patch is to fix checkpatch warning: "Macro argument 'iobase' may be better
> > as '(iobase)' to avoid precedence issues.
> >
> > Signed-off-by: Guru Mehar Rachaputi <[email protected]>
> > ---
> > drivers/staging/vt6655/mac.h | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/staging/vt6655/mac.h b/drivers/staging/vt6655/mac.h
> > index acf931c3f5fd..a33af2852227 100644
> > --- a/drivers/staging/vt6655/mac.h
> > +++ b/drivers/staging/vt6655/mac.h
> > @@ -537,9 +537,9 @@
> >
> > /*--------------------- Export Macros ------------------------------*/
> >
> > -#define VT6655_MAC_SELECT_PAGE0(iobase) iowrite8(0, iobase + MAC_REG_PAGE1SEL)
> > +#define VT6655_MAC_SELECT_PAGE0(iobase) iowrite8(0, (iobase) + MAC_REG_PAGE1SEL)
>
> This change really doesn't make much sense, right? How about turning
> these into an inline function instead? That would be the correct thing
> to do overall, right?
>
> thanks,
>
> greg k-h

Thanks for the reply and advice.
I have modified accordingly and sending in as a v2 patch for the above.

--
Thanks & Regards,
Guru