2023-02-05 01:29:24

by Randy Dunlap

Subject: [PATCH] sparc: allow sparc32 alias for archhelp

Currently, entering
$ make ARCH=sparc32 help
prints the archhelp text for sparc64.

Since "sparc32" is documented (Documentation/kbuild/kbuild.rst)
to be a recognized alias for 32-bit sparc, also support that
string in sparc's archhelp by allowing either ARCH=sparc or
ARCH=sparc32 for sparc32 archhelp.

Fixes: 5e53879008b9 ("sparc,sparc64: unify Makefile")
Signed-off-by: Randy Dunlap <[email protected]>
Cc: Sam Ravnborg <[email protected]>
Cc: "David S. Miller" <[email protected]>
Cc: [email protected]
Cc: Andrew Morton <[email protected]>
---
arch/sparc/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff -- a/arch/sparc/Makefile b/arch/sparc/Makefile
--- a/arch/sparc/Makefile
+++ b/arch/sparc/Makefile
@@ -83,7 +83,7 @@ vdso_install:
KBUILD_IMAGE := $(boot)/zImage

# Don't use tabs in echo arguments.
-ifeq ($(ARCH),sparc)
+ifeq ($(ARCH),$(filter $(ARCH),sparc sparc32))
define archhelp
echo '* image - kernel image ($(boot)/image)'
echo '* zImage - stripped kernel image ($(boot)/zImage)'

2023-02-05 08:55:30

by Sam Ravnborg

Subject: Re: [PATCH] sparc: allow sparc32 alias for archhelp

On Sat, Feb 04, 2023 at 05:29:15PM -0800, Randy Dunlap wrote:
> Currently, entering
> $ make ARCH=sparc32 help
> prints the archhelp text for sparc64.
>
> Since "sparc32" is documented (Documentation/kbuild/kbuild.rst)
> to be a recognized alias for 32-bit sparc, also support that
> string in sparc's archhelp by allowing either ARCH=sparc or
> ARCH=sparc32 for sparc32 archhelp.
>
> Fixes: 5e53879008b9 ("sparc,sparc64: unify Makefile")
> Signed-off-by: Randy Dunlap <[email protected]>
> Cc: Sam Ravnborg <[email protected]>
Acked-by: Sam Ravnborg <[email protected]>
> Cc: "David S. Miller" <[email protected]>
> Cc: [email protected]
> Cc: Andrew Morton <[email protected]>
I hope Andrew picks this up.

Sam

> ---
> arch/sparc/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff -- a/arch/sparc/Makefile b/arch/sparc/Makefile
> --- a/arch/sparc/Makefile
> +++ b/arch/sparc/Makefile
> @@ -83,7 +83,7 @@ vdso_install:
> KBUILD_IMAGE := $(boot)/zImage
>
> # Don't use tabs in echo arguments.
> -ifeq ($(ARCH),sparc)
> +ifeq ($(ARCH),$(filter $(ARCH),sparc sparc32))
> define archhelp
> echo '* image - kernel image ($(boot)/image)'
> echo '* zImage - stripped kernel image ($(boot)/zImage)'