2023-01-20 16:13:05

by Jianhua Lu

[permalink] [raw]
Subject: [PATCH v9 1/2] dt-bindings: leds: backlight: Add Kinetic KTZ8866 backlight

Add Kinetic KTZ8866 backlight binding documentation.

Signed-off-by: Jianhua Lu <[email protected]>
Reviewed-by: Krzysztof Kozlowski <[email protected]>
---
Changes in v2:
- Remove "items" between "compatible" and "const: kinetic,ktz8866".
- Change "additionalProperties" to "unevaluatedProperties".

Changes in v3:
- Add Krzysztof's R-b.

Changes in v4:
- Drop Krzysztof's R-b.
- Add some new properties.

Changes in v5:
- Add missing enum under property description.
- Rename uncorrect properties.

Changes in v6:
- Correct wrong property suffix and description.

Changes in v7:
- Add vddpos and vddeg supply.
- Use enable-gpios instead of defining enable pin.

Changes in v8:
- Rename current ramping time.
- Rename led ramping time.

Changes in v9:
- Add Krzysztof's R-b.
- Add missing 1μs to the enum of "kinetic,led-enable-ramp-delay-ms".

.../leds/backlight/kinetic,ktz8866.yaml | 76 +++++++++++++++++++
1 file changed, 76 insertions(+)
create mode 100644 Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml

diff --git a/Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml b/Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml
new file mode 100644
index 000000000000..e1191453c2f0
--- /dev/null
+++ b/Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml
@@ -0,0 +1,76 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/leds/backlight/kinetic,ktz8866.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Kinetic Technologies KTZ8866 backlight
+
+maintainers:
+ - Jianhua Lu <[email protected]>
+
+description: |
+ The Kinetic Technologies KTZ8866 is a high efficiency 6-channels-current-sinks
+ led backlight with dual lcd bias power.
+ https://www.kinet-ic.com/ktz8866/
+
+allOf:
+ - $ref: common.yaml#
+
+properties:
+ compatible:
+ const: kinetic,ktz8866
+
+ vddpos-supply:
+ description: positive boost supply regulator.
+
+ vddneg-supply:
+ description: negative boost supply regulator.
+
+ enable-gpios:
+ description: GPIO to use to enable/disable the backlight (HWEN pin).
+ maxItems: 1
+
+ current-num-sinks:
+ description: number of the LED current sinks' channels.
+ enum: [1, 2, 3, 4, 5, 6]
+
+ kinetic,current-ramp-delay-ms:
+ description: |
+ LED current ramping delay time in milliseconds, note that the
+ case 1 will be mapped to 1μs.
+ enum: [1, 2, 4, 8, 16, 32, 64, 128, 192, 256, 320, 384, 448, 512, 576, 640]
+
+ kinetic,led-enable-ramp-delay-ms:
+ description: |
+ LED on/off ramping delay time in milliseconds, note that the case 0 will be
+ mapped to 512μs because ktz8866 can't ramp faster than it.
+ enum: [0, 1, 2, 4, 8, 16, 32, 64, 128, 256, 512, 1024, 2048, 4096, 8192, 16384]
+
+ kinetic,enable-lcd-bias:
+ description: Set if we want to output bias power supply for LCD.
+ type: boolean
+
+required:
+ - compatible
+ - vddpos-supply
+ - vddneg-supply
+ - enable-gpios
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/gpio/gpio.h>
+
+ backlight {
+ compatible = "kinetic,ktz8866";
+
+ vddpos-supply = <&bl_vddpos_5p5>;
+ vddneg-supply = <&bl_vddneg_5p5>;
+ enable-gpios = <&tlmm 139 GPIO_ACTIVE_HIGH>;
+ current-num-sinks = <5>;
+ kinetic,current-ramp-delay-ms = <128>;
+ kinetic,led-enable-ramp-delay-ms = <1>;
+ kinetic,enable-lcd-bias;
+ };
--
2.39.1


2023-01-23 14:30:00

by Daniel Thompson

[permalink] [raw]
Subject: Re: [PATCH v9 1/2] dt-bindings: leds: backlight: Add Kinetic KTZ8866 backlight

On Fri, Jan 20, 2023 at 11:50:17PM +0800, Jianhua Lu wrote:
> Add Kinetic KTZ8866 backlight binding documentation.
>
> Signed-off-by: Jianhua Lu <[email protected]>
> Reviewed-by: Krzysztof Kozlowski <[email protected]>

Reviewed-by: Daniel Thompson <[email protected]>


Daniel.

2023-01-26 14:36:24

by Lee Jones

[permalink] [raw]
Subject: Re: [PATCH v9 1/2] dt-bindings: leds: backlight: Add Kinetic KTZ8866 backlight

On Fri, 20 Jan 2023, Jianhua Lu wrote:

> Add Kinetic KTZ8866 backlight binding documentation.
>
> Signed-off-by: Jianhua Lu <[email protected]>
> Reviewed-by: Krzysztof Kozlowski <[email protected]>
> ---
> Changes in v2:
> - Remove "items" between "compatible" and "const: kinetic,ktz8866".
> - Change "additionalProperties" to "unevaluatedProperties".
>
> Changes in v3:
> - Add Krzysztof's R-b.
>
> Changes in v4:
> - Drop Krzysztof's R-b.
> - Add some new properties.
>
> Changes in v5:
> - Add missing enum under property description.
> - Rename uncorrect properties.
>
> Changes in v6:
> - Correct wrong property suffix and description.
>
> Changes in v7:
> - Add vddpos and vddeg supply.
> - Use enable-gpios instead of defining enable pin.
>
> Changes in v8:
> - Rename current ramping time.
> - Rename led ramping time.
>
> Changes in v9:
> - Add Krzysztof's R-b.
> - Add missing 1μs to the enum of "kinetic,led-enable-ramp-delay-ms".
>
> .../leds/backlight/kinetic,ktz8866.yaml | 76 +++++++++++++++++++
> 1 file changed, 76 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml

Applied, thanks

--
Lee Jones [李琼斯]