Correct spelling problems for Documentation/block/ as reported
by codespell.
Signed-off-by: Randy Dunlap <[email protected]>
Cc: Jens Axboe <[email protected]>
Cc: [email protected]
Cc: Jonathan Corbet <[email protected]>
Cc: [email protected]
---
Documentation/block/data-integrity.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -- a/Documentation/block/data-integrity.rst b/Documentation/block/data-integrity.rst
--- a/Documentation/block/data-integrity.rst
+++ b/Documentation/block/data-integrity.rst
@@ -209,7 +209,7 @@ will require extra work due to the appli
sector must be set, and the bio should have all data pages
added. It is up to the caller to ensure that the bio does not
change while I/O is in progress.
- Complete bio with error if prepare failed for some reson.
+ Complete bio with error if prepare failed for some reason.
5.3 Passing Existing Integrity Metadata
On Thu, Jan 26, 2023 at 10:39:33PM -0800, Randy Dunlap wrote:
> diff -- a/Documentation/block/data-integrity.rst b/Documentation/block/data-integrity.rst
> --- a/Documentation/block/data-integrity.rst
> +++ b/Documentation/block/data-integrity.rst
> @@ -209,7 +209,7 @@ will require extra work due to the appli
> sector must be set, and the bio should have all data pages
> added. It is up to the caller to ensure that the bio does not
> change while I/O is in progress.
> - Complete bio with error if prepare failed for some reson.
> + Complete bio with error if prepare failed for some reason.
>
So if prepare returns error, bio is completed not successfully but also
errored?
--
An old man doll... just what I always wanted! - Clara
>Correct spelling problems for Documentation/block/ as reported
>by codespell.
>
>Signed-off-by: Randy Dunlap <[email protected]>
Reviewed-by: Mukesh Ojha <[email protected]>
-Mukesh
On 1/27/23 00:31, Bagas Sanjaya wrote:
> On Thu, Jan 26, 2023 at 10:39:33PM -0800, Randy Dunlap wrote:
>> diff -- a/Documentation/block/data-integrity.rst b/Documentation/block/data-integrity.rst
>> --- a/Documentation/block/data-integrity.rst
>> +++ b/Documentation/block/data-integrity.rst
>> @@ -209,7 +209,7 @@ will require extra work due to the appli
>> sector must be set, and the bio should have all data pages
>> added. It is up to the caller to ensure that the bio does not
>> change while I/O is in progress.
>> - Complete bio with error if prepare failed for some reson.
>> + Complete bio with error if prepare failed for some reason.
>>
>
> So if prepare returns error, bio is completed not successfully but also
> errored?
I think that
>> + Complete bio with error if prepare failed for some reason.
says that the caller of bio_integrity_prep() should treat the bio as an
error condition. I don't see any guarantee that the bio is completed
as far as adding an integrity payload to it, any more than what the bio
was upon calling bio_integrity_prep().
But I could also be wrong. :)
--
~Randy