2023-01-25 03:38:35

by Josh Poimboeuf

Subject: [PATCH 0/2] powerpc: Fix livepatch module re-patching issue

Fix a livepatch bug seen when reloading a patched module.

This is the powerpc counterpart to Song Liu's fix for a similar issue on
x86:

https://lkml.kernel.org/lkml/[email protected]

Josh Poimboeuf (2):
powerpc/module_64: Improve restore_r2() return semantics
powerpc/module_64: Fix "expected nop" error on module re-patching

arch/powerpc/kernel/module_64.c | 29 ++++++++++++++++++-----------
1 file changed, 18 insertions(+), 11 deletions(-)

--
2.39.0

2023-01-27 13:48:59

by Joe Lawrence

Subject: Re: [PATCH 0/2] powerpc: Fix livepatch module re-patching issue

On Tue, Jan 24, 2023 at 07:38:03PM -0800, Josh Poimboeuf wrote:
> Fix a livepatch bug seen when reloading a patched module.
>
> This is the powerpc counterpart to Song Liu's fix for a similar issue on
> x86:
>
> https://lkml.kernel.org/lkml/[email protected]
>
> Josh Poimboeuf (2):
> powerpc/module_64: Improve restore_r2() return semantics
> powerpc/module_64: Fix "expected nop" error on module re-patching
>
> arch/powerpc/kernel/module_64.c | 29 ++++++++++++++++++-----------
> 1 file changed, 18 insertions(+), 11 deletions(-)
>
> --
> 2.39.0
>

For the series,

Reviewed-and-tested-by: Joe Lawrence <[email protected]>

--
Joe

2023-02-04 17:24:03

by Josh Poimboeuf

Subject: Re: [PATCH 0/2] powerpc: Fix livepatch module re-patching issue

On Tue, Jan 24, 2023 at 07:38:03PM -0800, Josh Poimboeuf wrote:
> Fix a livepatch bug seen when reloading a patched module.
>
> This is the powerpc counterpart to Song Liu's fix for a similar issue on
> x86:
>
> https://lkml.kernel.org/lkml/[email protected]
>
> Josh Poimboeuf (2):
> powerpc/module_64: Improve restore_r2() return semantics
> powerpc/module_64: Fix "expected nop" error on module re-patching
>
> arch/powerpc/kernel/module_64.c | 29 ++++++++++++++++++-----------
> 1 file changed, 18 insertions(+), 11 deletions(-)

Hi Michael,

Ping? Any objections to this?

The x86 counterpart to this is queued for 6.3, it would be nice if this
also landed. We could take it through the livepatch tree if needed.

--
Josh

2023-02-05 00:46:28

by Michael Ellerman

Subject: Re: [PATCH 0/2] powerpc: Fix livepatch module re-patching issue

Josh Poimboeuf <[email protected]> writes:
> On Tue, Jan 24, 2023 at 07:38:03PM -0800, Josh Poimboeuf wrote:
>> Fix a livepatch bug seen when reloading a patched module.
>>
>> This is the powerpc counterpart to Song Liu's fix for a similar issue on
>> x86:
>>
>> https://lkml.kernel.org/lkml/[email protected]
>>
>> Josh Poimboeuf (2):
>> powerpc/module_64: Improve restore_r2() return semantics
>> powerpc/module_64: Fix "expected nop" error on module re-patching
>>
>> arch/powerpc/kernel/module_64.c | 29 ++++++++++++++++++-----------
>> 1 file changed, 18 insertions(+), 11 deletions(-)
>
> Hi Michael,
>
> Ping? Any objections to this?
>
> The x86 counterpart to this is queued for 6.3, it would be nice if this
> also landed. We could take it through the livepatch tree if needed.

It's in my next since about a week. Sorry I forgot to send the
"accepted" emails (which I still don't have automated :/ ).

337251c7114e1 ("powerpc/module_64: Fix "expected nop" error on module re-patching")

cheers

2023-02-05 00:47:37

by Michael Ellerman

Subject: Re: [PATCH 0/2] powerpc: Fix livepatch module re-patching issue

On Tue, 24 Jan 2023 19:38:03 -0800, Josh Poimboeuf wrote:
> Fix a livepatch bug seen when reloading a patched module.
>
> This is the powerpc counterpart to Song Liu's fix for a similar issue on
> x86:
>
> https://lkml.kernel.org/lkml/[email protected]
>
> [...]

Applied to powerpc/next.

[1/2] powerpc/module_64: Improve restore_r2() return semantics
https://git.kernel.org/powerpc/c/bc2c6f5695ffa05c838b8b6fc5cd581a672151a1
[2/2] powerpc/module_64: Fix "expected nop" error on module re-patching
https://git.kernel.org/powerpc/c/37251c7114e1b743b077ca74b93557c1ad92a97e

cheers

2023-02-05 16:22:08

by Josh Poimboeuf

Subject: Re: [PATCH 0/2] powerpc: Fix livepatch module re-patching issue

On Sun, Feb 05, 2023 at 11:46:12AM +1100, Michael Ellerman wrote:
> Josh Poimboeuf <[email protected]> writes:
> > On Tue, Jan 24, 2023 at 07:38:03PM -0800, Josh Poimboeuf wrote:
> >> Fix a livepatch bug seen when reloading a patched module.
> >>
> >> This is the powerpc counterpart to Song Liu's fix for a similar issue on
> >> x86:
> >>
> >> https://lkml.kernel.org/lkml/[email protected]
> >>
> >> Josh Poimboeuf (2):
> >> powerpc/module_64: Improve restore_r2() return semantics
> >> powerpc/module_64: Fix "expected nop" error on module re-patching
> >>
> >> arch/powerpc/kernel/module_64.c | 29 ++++++++++++++++++-----------
> >> 1 file changed, 18 insertions(+), 11 deletions(-)
> >
> > Hi Michael,
> >
> > Ping? Any objections to this?
> >
> > The x86 counterpart to this is queued for 6.3, it would be nice if this
> > also landed. We could take it through the livepatch tree if needed.
>
> It's in my next since about a week. Sorry I forgot to send the
> "accepted" emails (which I still don't have automated :/ ).
>
> 337251c7114e1 ("powerpc/module_64: Fix "expected nop" error on module re-patching")

Ah, I didn't think to look in -next. Thanks!

--
Josh