2023-01-27 22:13:36

by Arnd Bergmann

Subject: [PATCH] net: dsa: microchip: ptp: add one more PTP dependency

From: Arnd Bergmann <[email protected]>

When only NET_DSA_MICROCHIP_KSZ8863_SMI is built-in but
PTP is a loadable module, the ksz_ptp support still causes
a link failure:

ld.lld-16: error: undefined symbol: ptp_clock_index
>>> referenced by ksz_ptp.c
>>> drivers/net/dsa/microchip/ksz_ptp.o:(ksz_get_ts_info) in archive vmlinux.a

Add the same dependency here that exists with the KSZ9477_I2C
and KSZ_SPI drivers.

Fixes: eac1ea20261e ("net: dsa: microchip: ptp: add the posix clock support")
Signed-off-by: Arnd Bergmann <[email protected]>
---
drivers/net/dsa/microchip/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/net/dsa/microchip/Kconfig b/drivers/net/dsa/microchip/Kconfig
index 0546c573668a..11920939b6d8 100644
--- a/drivers/net/dsa/microchip/Kconfig
+++ b/drivers/net/dsa/microchip/Kconfig
@@ -36,6 +36,7 @@ config NET_DSA_MICROCHIP_KSZ_PTP
config NET_DSA_MICROCHIP_KSZ8863_SMI
tristate "KSZ series SMI connected switch driver"
depends on NET_DSA_MICROCHIP_KSZ_COMMON
+ depends on PTP_1588_CLOCK_OPTIONAL
select MDIO_BITBANG
help
Select to enable support for registering switches configured through
--
2.39.0

2023-01-27 23:58:28

by Richard Cochran

Subject: Re: [PATCH] net: dsa: microchip: ptp: add one more PTP dependency

On Fri, Jan 27, 2023 at 11:13:03PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <[email protected]>
>
> When only NET_DSA_MICROCHIP_KSZ8863_SMI is built-in but
> PTP is a loadable module, the ksz_ptp support still causes
> a link failure:
>
> ld.lld-16: error: undefined symbol: ptp_clock_index
> >>> referenced by ksz_ptp.c
> >>> drivers/net/dsa/microchip/ksz_ptp.o:(ksz_get_ts_info) in archive vmlinux.a
>
> Add the same dependency here that exists with the KSZ9477_I2C
> and KSZ_SPI drivers.
>
> Fixes: eac1ea20261e ("net: dsa: microchip: ptp: add the posix clock support")
> Signed-off-by: Arnd Bergmann <[email protected]>

Acked-by: Richard Cochran <[email protected]>

2023-01-28 21:44:54

by Arnd Bergmann

Subject: Re: [PATCH] net: dsa: microchip: ptp: add one more PTP dependency

On Sat, Jan 28, 2023, at 00:58, Richard Cochran wrote:
> On Fri, Jan 27, 2023 at 11:13:03PM +0100, Arnd Bergmann wrote:
>> From: Arnd Bergmann <[email protected]>
>>
>> When only NET_DSA_MICROCHIP_KSZ8863_SMI is built-in but
>> PTP is a loadable module, the ksz_ptp support still causes
>> a link failure:
>>
>> ld.lld-16: error: undefined symbol: ptp_clock_index
>> >>> referenced by ksz_ptp.c
>> >>> drivers/net/dsa/microchip/ksz_ptp.o:(ksz_get_ts_info) in archive vmlinux.a
>>
>> Add the same dependency here that exists with the KSZ9477_I2C
>> and KSZ_SPI drivers.
>>
>> Fixes: eac1ea20261e ("net: dsa: microchip: ptp: add the posix clock support")
>> Signed-off-by: Arnd Bergmann <[email protected]>
>
> Acked-by: Richard Cochran <[email protected]>

The randconfig builder just found another regression in the same
driver, I'll have to send a new version, so please disregard this one
for now.

Arnd