2023-01-29 09:12:03

by Bo Liu

[permalink] [raw]
Subject: [PATCH] vhost-scsi: convert sysfs snprintf and sprintf to sysfs_emit

Follow the advice of the Documentation/filesystems/sysfs.rst
and show() should only use sysfs_emit() or sysfs_emit_at()
when formatting the value to be returned to user space.

Signed-off-by: Bo Liu <[email protected]>
---
drivers/vhost/scsi.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c
index dca6346d75b3..5cdfa0bfc075 100644
--- a/drivers/vhost/scsi.c
+++ b/drivers/vhost/scsi.c
@@ -2092,7 +2092,7 @@ static ssize_t vhost_scsi_tpg_attrib_fabric_prot_type_show(
struct vhost_scsi_tpg *tpg = container_of(se_tpg,
struct vhost_scsi_tpg, se_tpg);

- return sprintf(page, "%d\n", tpg->tv_fabric_prot_type);
+ return sysfs_emit(page, "%d\n", tpg->tv_fabric_prot_type);
}

CONFIGFS_ATTR(vhost_scsi_tpg_attrib_, fabric_prot_type);
@@ -2202,7 +2202,7 @@ static ssize_t vhost_scsi_tpg_nexus_show(struct config_item *item, char *page)
mutex_unlock(&tpg->tv_tpg_mutex);
return -ENODEV;
}
- ret = snprintf(page, PAGE_SIZE, "%s\n",
+ ret = sysfs_emit(page, "%s\n",
tv_nexus->tvn_se_sess->se_node_acl->initiatorname);
mutex_unlock(&tpg->tv_tpg_mutex);

@@ -2427,7 +2427,7 @@ static void vhost_scsi_drop_tport(struct se_wwn *wwn)
static ssize_t
vhost_scsi_wwn_version_show(struct config_item *item, char *page)
{
- return sprintf(page, "TCM_VHOST fabric module %s on %s/%s"
+ return sysfs_emit(page, "TCM_VHOST fabric module %s on %s/%s"
"on "UTS_RELEASE"\n", VHOST_SCSI_VERSION, utsname()->sysname,
utsname()->machine);
}
--
2.27.0



2023-01-29 10:32:39

by Simon Horman

[permalink] [raw]
Subject: Re: [PATCH] vhost-scsi: convert sysfs snprintf and sprintf to sysfs_emit

On Sun, Jan 29, 2023 at 04:11:45AM -0500, Bo Liu wrote:
> Follow the advice of the Documentation/filesystems/sysfs.rst
> and show() should only use sysfs_emit() or sysfs_emit_at()
> when formatting the value to be returned to user space.
>
> Signed-off-by: Bo Liu <[email protected]>

FWIIW,

Reviewed-by: Simon Horman <[email protected]>


2023-01-30 19:34:15

by Stefan Hajnoczi

[permalink] [raw]
Subject: Re: [PATCH] vhost-scsi: convert sysfs snprintf and sprintf to sysfs_emit

On Sun, Jan 29, 2023 at 04:11:45AM -0500, Bo Liu wrote:
> Follow the advice of the Documentation/filesystems/sysfs.rst
> and show() should only use sysfs_emit() or sysfs_emit_at()
> when formatting the value to be returned to user space.
>
> Signed-off-by: Bo Liu <[email protected]>
> ---
> drivers/vhost/scsi.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)

Reviewed-by: Stefan Hajnoczi <[email protected]>

Attachments:
(No filename) (430.00 B)
 signature.asc (488.00 B)
 Download all attachments

2023-01-31 07:02:12

by Chaitanya Kulkarni

[permalink] [raw]
Subject: Re: [PATCH] vhost-scsi: convert sysfs snprintf and sprintf to sysfs_emit

On 1/30/23 11:33, Stefan Hajnoczi wrote:
> On Sun, Jan 29, 2023 at 04:11:45AM -0500, Bo Liu wrote:
>> Follow the advice of the Documentation/filesystems/sysfs.rst
>> and show() should only use sysfs_emit() or sysfs_emit_at()
>> when formatting the value to be returned to user space.
>>
>> Signed-off-by: Bo Liu <[email protected]>
>> ---
>> drivers/vhost/scsi.c | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>

Looks good.

Reviewed-by: Chaitanya Kulkarni <[email protected]>

-ck