2023-01-31 10:34:52

by Corentin LABBE

[permalink] [raw]
Subject: Re: [PATCH] hw_random: rockchip: import driver from vendor tree

Le Tue, Sep 20, 2022 at 10:35:44AM +0100, Robin Murphy a ?crit :
> On 2022-09-19 22:00, Jason A. Donenfeld wrote:
> > The Rockchip driver has long existed out of tree, but not upstream.
> > There is support for it upstream in u-boot, but not in Linux proper.
> > This commit imports the GPLv2 driver written by Lin Jinhan, together
> > with the DTS and config blobs from Wevsty.
>
> Note that Corentin has a series enabling the full crypto driver for
> RK3328 and RK3399[1], so it would seem more sensible to add TRNG support
> to that. Having confliciting compatibles for the same hardware that
> force the user to change their DT to choose one functionality or the
> other isn't good (plus there's also no binding for this one).
>
> Robin.
>

Hello

I am very interested on how this serie was tested and which tools was used to ensure output was random.
And how did you get that CRYPTO_V1_TRNG_SAMPLE_PERIOD(100); was the best choice.

Thanks
Regards