2023-01-31 18:14:48

by Guru Mehar Rachaputi

Subject: [PATCH] staging: pi433: Added information about bit_rate configuration

Information in the TODO file for bit_rate configuration is
insufficient.

This patch adds information on how to approach when considering
to modify bit_rate to support upto 300kbps.

Signed-off-by: Guru Mehar Rachaputi <[email protected]>
---
drivers/staging/pi433/TODO | 3 +++
1 file changed, 3 insertions(+)

diff --git a/drivers/staging/pi433/TODO b/drivers/staging/pi433/TODO
index 5cf3fd99d521..daa0dbcf6d53 100644
--- a/drivers/staging/pi433/TODO
+++ b/drivers/staging/pi433/TODO
@@ -3,3 +3,6 @@
* Some missing data (marked with ###) needs to be added in the documentation
* Change (struct pi433_tx_cfg)->bit_rate to be a u32 so that we can support
bit rates up to 300kbps per the spec.
+ -> This configuration needs to be moved to sysfs instead of being done through
+ IOCTL. Goind forward, we need to port userspace tools to use sysfs instead
+ of IOCTL and then we would delete IOCTL.
--
2.34.1


--
Thanks & Regards,
Guru

2023-02-01 06:16:16

by Dan Carpenter

Subject: Re: [PATCH] staging: pi433: Added information about bit_rate configuration

On Tue, Jan 31, 2023 at 07:14:39PM +0100, Guru Mehar Rachaputi wrote:
> Information in the TODO file for bit_rate configuration is
> insufficient.
>
> This patch adds information on how to approach when considering
> to modify bit_rate to support upto 300kbps.
>
> Signed-off-by: Guru Mehar Rachaputi <[email protected]>
> ---

Thanks!

Acked-by: Dan Carpenter <[email protected]>

regards,
dan carpenter