2023-02-01 13:56:25

by 付元力 Jerry Fu

Subject: [PATCH] hung_task: Print message when hung_task_warnings gets down to zero.

It's useful to report it when hung_task_warnings gets down to zero,
so that we can know if kernel log was lost or there is no hung task
was detected.

Signed-off-by: fuyuanli <[email protected]>
---
kernel/hung_task.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/kernel/hung_task.c b/kernel/hung_task.c
index bb2354f73ded..ff479c51143d 100644
--- a/kernel/hung_task.c
+++ b/kernel/hung_task.c
@@ -142,6 +142,8 @@ static void check_hung_task(struct task_struct *t, unsigned long timeout)

if (sysctl_hung_task_all_cpu_backtrace)
hung_task_show_all_bt = true;
+ if (!sysctl_hung_task_warnings)
+ pr_info("Future hung task reports are suppressed, see sysctl kernel.hung_task_warnings\n");
}

touch_nmi_watchdog();
--
2.17.1

2023-02-02 10:00:25

by Petr Mladek

Subject: Re: [PATCH] hung_task: Print message when hung_task_warnings gets down to zero.

On Wed 2023-02-01 21:54:33, fuyuanli wrote:
> It's useful to report it when hung_task_warnings gets down to zero,
> so that we can know if kernel log was lost or there is no hung task
> was detected.
>
> Signed-off-by: fuyuanli <[email protected]>

Looks good to me.

Reviewed-by: Petr Mladek <[email protected]>

Best Regards,
Petr