2021-01-08 16:57:28

by Quentin Perret

Subject: [PATCH] KVM: Documentation: Fix spec for KVM_CAP_ENABLE_CAP_VM

The documentation classifies KVM_ENABLE_CAP with KVM_CAP_ENABLE_CAP_VM
as a vcpu ioctl, which is incorrect. Fix it by specifying it as a VM
ioctl.

Fixes: e5d83c74a580 ("kvm: make KVM_CAP_ENABLE_CAP_VM architecture agnostic")
Signed-off-by: Quentin Perret <[email protected]>
---
Documentation/virt/kvm/api.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/virt/kvm/api.rst b/Documentation/virt/kvm/api.rst
index 70254eaa5229..68898b623d86 100644
--- a/Documentation/virt/kvm/api.rst
+++ b/Documentation/virt/kvm/api.rst
@@ -1328,7 +1328,7 @@ documentation when it pops into existence).

:Capability: KVM_CAP_ENABLE_CAP_VM
:Architectures: all
-:Type: vcpu ioctl
+:Type: vm ioctl
:Parameters: struct kvm_enable_cap (in)
:Returns: 0 on success; -1 on error

--
2.30.0.284.gd98b1dd5eaa7-goog

2021-01-15 13:53:04

by Quentin Perret

Subject: Re: [PATCH] KVM: Documentation: Fix spec for KVM_CAP_ENABLE_CAP_VM

On Friday 08 Jan 2021 at 16:53:49 (+0000), Quentin Perret wrote:
> The documentation classifies KVM_ENABLE_CAP with KVM_CAP_ENABLE_CAP_VM
> as a vcpu ioctl, which is incorrect. Fix it by specifying it as a VM
> ioctl.

Anything I should do on this one?

Thanks,
Quentin

2021-01-15 16:54:11

by Will Deacon

Subject: Re: [PATCH] KVM: Documentation: Fix spec for KVM_CAP_ENABLE_CAP_VM

On Fri, Jan 08, 2021 at 04:53:49PM +0000, Quentin Perret wrote:
> The documentation classifies KVM_ENABLE_CAP with KVM_CAP_ENABLE_CAP_VM
> as a vcpu ioctl, which is incorrect. Fix it by specifying it as a VM
> ioctl.
>
> Fixes: e5d83c74a580 ("kvm: make KVM_CAP_ENABLE_CAP_VM architecture agnostic")
> Signed-off-by: Quentin Perret <[email protected]>
> ---
> Documentation/virt/kvm/api.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/virt/kvm/api.rst b/Documentation/virt/kvm/api.rst
> index 70254eaa5229..68898b623d86 100644
> --- a/Documentation/virt/kvm/api.rst
> +++ b/Documentation/virt/kvm/api.rst
> @@ -1328,7 +1328,7 @@ documentation when it pops into existence).
>
> :Capability: KVM_CAP_ENABLE_CAP_VM
> :Architectures: all
> -:Type: vcpu ioctl
> +:Type: vm ioctl
> :Parameters: struct kvm_enable_cap (in)
> :Returns: 0 on success; -1 on error

I tripped over this as well, so:

Acked-by: Will Deacon <[email protected]>

Will

2021-01-15 22:35:48

by Sean Christopherson

Subject: Re: [PATCH] KVM: Documentation: Fix spec for KVM_CAP_ENABLE_CAP_VM

On Fri, Jan 15, 2021, Will Deacon wrote:
> On Fri, Jan 08, 2021 at 04:53:49PM +0000, Quentin Perret wrote:
> > The documentation classifies KVM_ENABLE_CAP with KVM_CAP_ENABLE_CAP_VM
> > as a vcpu ioctl, which is incorrect. Fix it by specifying it as a VM
> > ioctl.

On a related topic, x86 should report KVM_CAP_ENABLE_CAP as supported, it's had
a vCPU version since commit 5c919412fe61 ("kvm/x86: Hyper-V synthetic interrupt
controller"). I'll send a patch.

> > Fixes: e5d83c74a580 ("kvm: make KVM_CAP_ENABLE_CAP_VM architecture agnostic")
> > Signed-off-by: Quentin Perret <[email protected]>
> > ---
> > Documentation/virt/kvm/api.rst | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Documentation/virt/kvm/api.rst b/Documentation/virt/kvm/api.rst
> > index 70254eaa5229..68898b623d86 100644
> > --- a/Documentation/virt/kvm/api.rst
> > +++ b/Documentation/virt/kvm/api.rst
> > @@ -1328,7 +1328,7 @@ documentation when it pops into existence).
> >
> > :Capability: KVM_CAP_ENABLE_CAP_VM
> > :Architectures: all
> > -:Type: vcpu ioctl
> > +:Type: vm ioctl
> > :Parameters: struct kvm_enable_cap (in)
> > :Returns: 0 on success; -1 on error
>
> I tripped over this as well, so:
>
> Acked-by: Will Deacon <[email protected]>

The problem is that you read the documentation. Who does that?

Reviewed-by: Sean Christopherson <[email protected]>

2021-01-18 17:50:40

by Paolo Bonzini

Subject: Re: [PATCH] KVM: Documentation: Fix spec for KVM_CAP_ENABLE_CAP_VM

On 15/01/21 17:50, Will Deacon wrote:
> On Fri, Jan 08, 2021 at 04:53:49PM +0000, Quentin Perret wrote:
>> The documentation classifies KVM_ENABLE_CAP with KVM_CAP_ENABLE_CAP_VM
>> as a vcpu ioctl, which is incorrect. Fix it by specifying it as a VM
>> ioctl.
>>
>> Fixes: e5d83c74a580 ("kvm: make KVM_CAP_ENABLE_CAP_VM architecture agnostic")
>> Signed-off-by: Quentin Perret <[email protected]>
>> ---
>> Documentation/virt/kvm/api.rst | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/virt/kvm/api.rst b/Documentation/virt/kvm/api.rst
>> index 70254eaa5229..68898b623d86 100644
>> --- a/Documentation/virt/kvm/api.rst
>> +++ b/Documentation/virt/kvm/api.rst
>> @@ -1328,7 +1328,7 @@ documentation when it pops into existence).
>>
>> :Capability: KVM_CAP_ENABLE_CAP_VM
>> :Architectures: all
>> -:Type: vcpu ioctl
>> +:Type: vm ioctl
>> :Parameters: struct kvm_enable_cap (in)
>> :Returns: 0 on success; -1 on error
>
> I tripped over this as well, so:
>
> Acked-by: Will Deacon <[email protected]>
>
> Will
>

Queued, thanks.

Paolo