2021-01-19 17:00:46

by Johannes Weiner

[permalink] [raw]
Subject: Re: [PATCH v2 2/2] cgroup: update PSI file description in docs

On Sat, Jan 16, 2021 at 06:36:34PM +0100, Odin Ugedal wrote:
> Update PSI file description in cgroup-v2 docs to reflect the current
> implementation.
>
> Signed-off-by: Odin Ugedal <[email protected]>
> ---
> Documentation/admin-guide/cgroup-v2.rst | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/admin-guide/cgroup-v2.rst b/Documentation/admin-guide/cgroup-v2.rst
> index 63521cd36ce5..f638c9d3d9f2 100644
> --- a/Documentation/admin-guide/cgroup-v2.rst
> +++ b/Documentation/admin-guide/cgroup-v2.rst
> @@ -1029,7 +1029,7 @@ All time durations are in microseconds.
> one number is written, $MAX is updated.
>
> cpu.pressure
> - A read-only nested-key file which exists on non-root cgroups.
> + A read-only nested-keyed file.

Could you please also change the 'read-only' to 'read-write'?

With that, please feel free to add:
Acked-by: Johannes Weiner <[email protected]>


2021-01-19 17:08:42

by Tejun Heo

[permalink] [raw]
Subject: Re: [PATCH v2 2/2] cgroup: update PSI file description in docs

On Tue, Jan 19, 2021 at 11:56:18AM -0500, Johannes Weiner wrote:
> On Sat, Jan 16, 2021 at 06:36:34PM +0100, Odin Ugedal wrote:
> > Update PSI file description in cgroup-v2 docs to reflect the current
> > implementation.
> >
> > Signed-off-by: Odin Ugedal <[email protected]>
> > ---
> > Documentation/admin-guide/cgroup-v2.rst | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/Documentation/admin-guide/cgroup-v2.rst b/Documentation/admin-guide/cgroup-v2.rst
> > index 63521cd36ce5..f638c9d3d9f2 100644
> > --- a/Documentation/admin-guide/cgroup-v2.rst
> > +++ b/Documentation/admin-guide/cgroup-v2.rst
> > @@ -1029,7 +1029,7 @@ All time durations are in microseconds.
> > one number is written, $MAX is updated.
> >
> > cpu.pressure
> > - A read-only nested-key file which exists on non-root cgroups.
> > + A read-only nested-keyed file.
>
> Could you please also change the 'read-only' to 'read-write'?
>
> With that, please feel free to add:
> Acked-by: Johannes Weiner <[email protected]>

Applied w/ the suggested change.

Thanks.

--
tejun