2021-01-27 05:48:50

by FLAVIO SULIGOI

[permalink] [raw]
Subject: [PATCH v1] mtd: spi-nor: core: fix/remove references to spi-nor.c

The old file:

drivers/mtd/spi-nor/spi-nor.c

is not more present and now some of its code is
contained in:

drivers/mtd/spi-nor/core.c

This patch fix/remove the references to the old
spi-nor.c file.

Signed-off-by: Flavio Suligoi <[email protected]>
---
Documentation/driver-api/mtd/spi-nor.rst | 2 +-
drivers/mtd/spi-nor/core.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/Documentation/driver-api/mtd/spi-nor.rst b/Documentation/driver-api/mtd/spi-nor.rst
index 4a3adca417fd..bf2db371d3fb 100644
--- a/Documentation/driver-api/mtd/spi-nor.rst
+++ b/Documentation/driver-api/mtd/spi-nor.rst
@@ -61,7 +61,7 @@ Part III - How can drivers use the framework?

The main API is spi_nor_scan(). Before you call the hook, a driver should
initialize the necessary fields for spi_nor{}. Please see
-drivers/mtd/spi-nor/spi-nor.c for detail. Please also refer to spi-fsl-qspi.c
+drivers/mtd/spi-nor/core.c for detail. Please also refer to spi-fsl-qspi.c
when you want to write a new driver for a SPI NOR controller.
Another API is spi_nor_restore(), this is used to restore the status of SPI
flash chip such as addressing mode. Call it whenever detach the driver from
diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c
index 20df44b753da..6ae7d4c2d2b6 100644
--- a/drivers/mtd/spi-nor/core.c
+++ b/drivers/mtd/spi-nor/core.c
@@ -3701,8 +3701,8 @@ static void spi_nor_shutdown(struct spi_mem *spimem)
* encourage new users to add support to the spi-nor library, and simply bind
* against a generic string here (e.g., "jedec,spi-nor").
*
- * Many flash names are kept here in this list (as well as in spi-nor.c) to
- * keep them available as module aliases for existing platforms.
+ * Many flash names are kept here in this list to keep them available
+ * as module aliases for existing platforms.
*/
static const struct spi_device_id spi_nor_dev_ids[] = {
/*
--
2.25.1


2021-01-30 18:53:28

by J. Neuschäfer

[permalink] [raw]
Subject: Re: [PATCH v1] mtd: spi-nor: core: fix/remove references to spi-nor.c

On Tue, Jan 26, 2021 at 10:25:16AM +0100, Flavio Suligoi wrote:
> The old file:
>
> drivers/mtd/spi-nor/spi-nor.c
>
> is not more present and now some of its code is
> contained in:
>
> drivers/mtd/spi-nor/core.c
>
> This patch fix/remove the references to the old
> spi-nor.c file.
>
> Signed-off-by: Flavio Suligoi <[email protected]>
> ---

Reviewed-by: Jonathan Neuschäfer <[email protected]>

Thanks.


> Documentation/driver-api/mtd/spi-nor.rst | 2 +-
> drivers/mtd/spi-nor/core.c | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/driver-api/mtd/spi-nor.rst b/Documentation/driver-api/mtd/spi-nor.rst
> index 4a3adca417fd..bf2db371d3fb 100644
> --- a/Documentation/driver-api/mtd/spi-nor.rst
> +++ b/Documentation/driver-api/mtd/spi-nor.rst
> @@ -61,7 +61,7 @@ Part III - How can drivers use the framework?
>
> The main API is spi_nor_scan(). Before you call the hook, a driver should
> initialize the necessary fields for spi_nor{}. Please see
> -drivers/mtd/spi-nor/spi-nor.c for detail. Please also refer to spi-fsl-qspi.c
> +drivers/mtd/spi-nor/core.c for detail. Please also refer to spi-fsl-qspi.c
> when you want to write a new driver for a SPI NOR controller.
> Another API is spi_nor_restore(), this is used to restore the status of SPI
> flash chip such as addressing mode. Call it whenever detach the driver from
> diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c
> index 20df44b753da..6ae7d4c2d2b6 100644
> --- a/drivers/mtd/spi-nor/core.c
> +++ b/drivers/mtd/spi-nor/core.c
> @@ -3701,8 +3701,8 @@ static void spi_nor_shutdown(struct spi_mem *spimem)
> * encourage new users to add support to the spi-nor library, and simply bind
> * against a generic string here (e.g., "jedec,spi-nor").
> *
> - * Many flash names are kept here in this list (as well as in spi-nor.c) to
> - * keep them available as module aliases for existing platforms.
> + * Many flash names are kept here in this list to keep them available
> + * as module aliases for existing platforms.
> */
> static const struct spi_device_id spi_nor_dev_ids[] = {
> /*
> --
> 2.25.1
>


Attachments:
(No filename) (2.18 kB)
signature.asc (849.00 B)
Download all attachments

2021-12-23 08:12:45

by Tudor Ambarus

[permalink] [raw]
Subject: Re: [PATCH v1] mtd: spi-nor: core: fix/remove references to spi-nor.c

On Tue, 26 Jan 2021 10:25:16 +0100, Flavio Suligoi wrote:
> The old file:
>
> drivers/mtd/spi-nor/spi-nor.c
>
> is not more present and now some of its code is
> contained in:
>
> [...]

Applied to spi-nor/next, thanks!

[1/1] mtd: spi-nor: core: fix/remove references to spi-nor.c
https://git.kernel.org/mtd/c/e7ad9f59f746

Best regards,
--
Tudor Ambarus <[email protected]>