2021-02-11 20:40:31

by Greg KH

Subject: Re: [PATCH] staging: wimax/i2400m: fix some byte order issues found by sparse

On Fri, Feb 12, 2021 at 01:59:08AM +0530, Anirudh Rayabharam wrote:
> Fix sparse byte-order warnings in the i2400m_bm_cmd_prepare()
> function:
>
> wimax/i2400m/fw.c:194:36: warning: restricted __le32 degrades to integer
> wimax/i2400m/fw.c:195:34: warning: invalid assignment: +=
> wimax/i2400m/fw.c:195:34: left side has type unsigned int
> wimax/i2400m/fw.c:195:34: right side has type restricted __le32
> wimax/i2400m/fw.c:196:32: warning: restricted __le32 degrades to integer
> wimax/i2400m/fw.c:196:47: warning: restricted __le32 degrades to integer
> wimax/i2400m/fw.c:196:66: warning: restricted __le32 degrades to integer
>
> Signed-off-by: Anirudh Rayabharam <[email protected]>
> ---
> drivers/staging/wimax/i2400m/fw.c | 14 +++++++++-----
> 1 file changed, 9 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/wimax/i2400m/fw.c b/drivers/staging/wimax/i2400m/fw.c
> index b2fd4bd2c5f9..bce651a6b543 100644
> --- a/drivers/staging/wimax/i2400m/fw.c
> +++ b/drivers/staging/wimax/i2400m/fw.c
> @@ -189,12 +189,16 @@ void i2400m_bm_cmd_prepare(struct i2400m_bootrom_header *cmd)
> {
> if (i2400m_brh_get_use_checksum(cmd)) {
> int i;
> - u32 checksum = 0;
> + __le32 checksum = 0;

__le32 is only for when the data crosses the kernel/user boundry, just
use le32 in the kernel for stuff like this.

> const u32 *checksum_ptr = (void *) cmd->payload;

Add a blank line here, right?

thanks,

greg k-h

2021-02-12 14:32:24

by Anirudh Rayabharam

Subject: Re: [PATCH] staging: wimax/i2400m: fix some byte order issues found by sparse

On Thu, Feb 11, 2021 at 09:35:27PM +0100, Greg KH wrote:
> On Fri, Feb 12, 2021 at 01:59:08AM +0530, Anirudh Rayabharam wrote:
> > Fix sparse byte-order warnings in the i2400m_bm_cmd_prepare()
> > function:
> >
> > wimax/i2400m/fw.c:194:36: warning: restricted __le32 degrades to integer
> > wimax/i2400m/fw.c:195:34: warning: invalid assignment: +=
> > wimax/i2400m/fw.c:195:34: left side has type unsigned int
> > wimax/i2400m/fw.c:195:34: right side has type restricted __le32
> > wimax/i2400m/fw.c:196:32: warning: restricted __le32 degrades to integer
> > wimax/i2400m/fw.c:196:47: warning: restricted __le32 degrades to integer
> > wimax/i2400m/fw.c:196:66: warning: restricted __le32 degrades to integer
> >
> > Signed-off-by: Anirudh Rayabharam <[email protected]>
> > ---
> > drivers/staging/wimax/i2400m/fw.c | 14 +++++++++-----
> > 1 file changed, 9 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/staging/wimax/i2400m/fw.c b/drivers/staging/wimax/i2400m/fw.c
> > index b2fd4bd2c5f9..bce651a6b543 100644
> > --- a/drivers/staging/wimax/i2400m/fw.c
> > +++ b/drivers/staging/wimax/i2400m/fw.c
> > @@ -189,12 +189,16 @@ void i2400m_bm_cmd_prepare(struct i2400m_bootrom_header *cmd)
> > {
> > if (i2400m_brh_get_use_checksum(cmd)) {
> > int i;
> > - u32 checksum = 0;
> > + __le32 checksum = 0;
>
> __le32 is only for when the data crosses the kernel/user boundry, just
> use le32 in the kernel for stuff like this.
>
But that throws a compile error. Also, I don't see le32 defined
in any common header. It is defined in fs/ntfs/types.h but that's not
accessible here.

> > const u32 *checksum_ptr = (void *) cmd->payload;
>
> Add a blank line here, right?
It wasn't there before but makes sense. I'll send v2 with this change.

Thanks!

- Anirudh.

2021-02-12 14:44:53

by Greg KH

Subject: Re: [PATCH] staging: wimax/i2400m: fix some byte order issues found by sparse

On Fri, Feb 12, 2021 at 08:00:25PM +0530, Anirudh Rayabharam wrote:
> On Thu, Feb 11, 2021 at 09:35:27PM +0100, Greg KH wrote:
> > On Fri, Feb 12, 2021 at 01:59:08AM +0530, Anirudh Rayabharam wrote:
> > > Fix sparse byte-order warnings in the i2400m_bm_cmd_prepare()
> > > function:
> > >
> > > wimax/i2400m/fw.c:194:36: warning: restricted __le32 degrades to integer
> > > wimax/i2400m/fw.c:195:34: warning: invalid assignment: +=
> > > wimax/i2400m/fw.c:195:34: left side has type unsigned int
> > > wimax/i2400m/fw.c:195:34: right side has type restricted __le32
> > > wimax/i2400m/fw.c:196:32: warning: restricted __le32 degrades to integer
> > > wimax/i2400m/fw.c:196:47: warning: restricted __le32 degrades to integer
> > > wimax/i2400m/fw.c:196:66: warning: restricted __le32 degrades to integer
> > >
> > > Signed-off-by: Anirudh Rayabharam <[email protected]>
> > > ---
> > > drivers/staging/wimax/i2400m/fw.c | 14 +++++++++-----
> > > 1 file changed, 9 insertions(+), 5 deletions(-)
> > >
> > > diff --git a/drivers/staging/wimax/i2400m/fw.c b/drivers/staging/wimax/i2400m/fw.c
> > > index b2fd4bd2c5f9..bce651a6b543 100644
> > > --- a/drivers/staging/wimax/i2400m/fw.c
> > > +++ b/drivers/staging/wimax/i2400m/fw.c
> > > @@ -189,12 +189,16 @@ void i2400m_bm_cmd_prepare(struct i2400m_bootrom_header *cmd)
> > > {
> > > if (i2400m_brh_get_use_checksum(cmd)) {
> > > int i;
> > > - u32 checksum = 0;
> > > + __le32 checksum = 0;
> >
> > __le32 is only for when the data crosses the kernel/user boundry, just
> > use le32 in the kernel for stuff like this.
> >
> But that throws a compile error.

What error?

> Also, I don't see le32 defined
> in any common header. It is defined in fs/ntfs/types.h but that's not
> accessible here.

Ah, my fault, you are right, nevermind.

> > > const u32 *checksum_ptr = (void *) cmd->payload;
> >
> > Add a blank line here, right?
> It wasn't there before but makes sense. I'll send v2 with this change.

Thanks.

greg k-h

2021-02-12 17:19:18

by Anirudh Rayabharam

Subject: Re: [PATCH] staging: wimax/i2400m: fix some byte order issues found by sparse

On Fri, Feb 12, 2021 at 03:43:10PM +0100, Greg KH wrote:
> On Fri, Feb 12, 2021 at 08:00:25PM +0530, Anirudh Rayabharam wrote:
> > On Thu, Feb 11, 2021 at 09:35:27PM +0100, Greg KH wrote:
> > > On Fri, Feb 12, 2021 at 01:59:08AM +0530, Anirudh Rayabharam wrote:
> > > > Fix sparse byte-order warnings in the i2400m_bm_cmd_prepare()
> > > > function:
> > > >
> > > > wimax/i2400m/fw.c:194:36: warning: restricted __le32 degrades to integer
> > > > wimax/i2400m/fw.c:195:34: warning: invalid assignment: +=
> > > > wimax/i2400m/fw.c:195:34: left side has type unsigned int
> > > > wimax/i2400m/fw.c:195:34: right side has type restricted __le32
> > > > wimax/i2400m/fw.c:196:32: warning: restricted __le32 degrades to integer
> > > > wimax/i2400m/fw.c:196:47: warning: restricted __le32 degrades to integer
> > > > wimax/i2400m/fw.c:196:66: warning: restricted __le32 degrades to integer
> > > >
> > > > Signed-off-by: Anirudh Rayabharam <[email protected]>
> > > > ---
> > > > drivers/staging/wimax/i2400m/fw.c | 14 +++++++++-----
> > > > 1 file changed, 9 insertions(+), 5 deletions(-)
> > > >
> > > > diff --git a/drivers/staging/wimax/i2400m/fw.c b/drivers/staging/wimax/i2400m/fw.c
> > > > index b2fd4bd2c5f9..bce651a6b543 100644
> > > > --- a/drivers/staging/wimax/i2400m/fw.c
> > > > +++ b/drivers/staging/wimax/i2400m/fw.c
> > > > @@ -189,12 +189,16 @@ void i2400m_bm_cmd_prepare(struct i2400m_bootrom_header *cmd)
> > > > {
> > > > if (i2400m_brh_get_use_checksum(cmd)) {
> > > > int i;
> > > > - u32 checksum = 0;
> > > > + __le32 checksum = 0;
> > >
> > > __le32 is only for when the data crosses the kernel/user boundry, just
> > > use le32 in the kernel for stuff like this.
> > >
> > But that throws a compile error.
>
> What error?

drivers/staging/wimax/i2400m/fw.c:192:3: error: unknown type name
‘le32’; did you mean ‘__le32’?

- Anirudh