2021-03-03 01:30:55

by Jarkko Sakkinen

Subject: [PATCH] tpm: Remove unintentional dump_stack() call

From: Jarkko Sakkinen <[email protected]>

Somewhere along the line, probably during a rebase, an unintentional
dump_stack() got included. Revert this change.

Reported-by: Rikard Falkeborn <[email protected]>
Fixes: 90cba8d20f8b ("tpm/ppi: Constify static struct attribute_group")
Signed-off-by: Jarkko Sakkinen <[email protected]>
---
drivers/char/tpm/tpm-chip.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/char/tpm/tpm-chip.c b/drivers/char/tpm/tpm-chip.c
index 19e23fcc6bc8..ddaeceb7e109 100644
--- a/drivers/char/tpm/tpm-chip.c
+++ b/drivers/char/tpm/tpm-chip.c
@@ -278,8 +278,6 @@ static void tpm_devs_release(struct device *dev)
{
struct tpm_chip *chip = container_of(dev, struct tpm_chip, devs);

- dump_stack();
-
/* release the master device reference */
put_device(&chip->dev);
}
--
2.30.1

2021-03-04 05:22:31

by Rikard Falkeborn

Subject: Re: [PATCH] tpm: Remove unintentional dump_stack() call

On Mon, Mar 01, 2021 at 11:44:09AM +0200, [email protected] wrote:
> From: Jarkko Sakkinen <[email protected]>
>
> Somewhere along the line, probably during a rebase, an unintentional
> dump_stack() got included. Revert this change.
>
> Reported-by: Rikard Falkeborn <[email protected]>
> Fixes: 90cba8d20f8b ("tpm/ppi: Constify static struct attribute_group")
> Signed-off-by: Jarkko Sakkinen <[email protected]>
> ---
> drivers/char/tpm/tpm-chip.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/char/tpm/tpm-chip.c b/drivers/char/tpm/tpm-chip.c
> index 19e23fcc6bc8..ddaeceb7e109 100644
> --- a/drivers/char/tpm/tpm-chip.c
> +++ b/drivers/char/tpm/tpm-chip.c
> @@ -278,8 +278,6 @@ static void tpm_devs_release(struct device *dev)
> {
> struct tpm_chip *chip = container_of(dev, struct tpm_chip, devs);
>
> - dump_stack();
> -
> /* release the master device reference */
> put_device(&chip->dev);
> }
> --
> 2.30.1
>

Acked-by: Rikard Falkeborn <[email protected]>