2021-02-22 08:52:48

by Jiapeng Chong

Subject: [PATCH] vt: convert sysfs sprintf/snprintf family to sysfs_emit

Fix the following coccicheck warning:

./drivers/tty/vt/vt.c:3909:8-16: WARNING: use scnprintf or sprintf.
./drivers/tty/vt/vt.c:3917:8-16: WARNING: use scnprintf or sprintf

Reported-by: Abaci Robot<[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
drivers/tty/vt/vt.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/tty/vt/vt.c b/drivers/tty/vt/vt.c
index 284b072..cdf8132 100644
--- a/drivers/tty/vt/vt.c
+++ b/drivers/tty/vt/vt.c
@@ -3906,7 +3906,7 @@ static ssize_t show_bind(struct device *dev, struct device_attribute *attr,
bind = con_is_bound(con->con);
console_unlock();

- return snprintf(buf, PAGE_SIZE, "%i\n", bind);
+ return sysfs_emit(buf, "%i\n", bind);
}

static ssize_t show_name(struct device *dev, struct device_attribute *attr,
@@ -3914,9 +3914,8 @@ static ssize_t show_name(struct device *dev, struct device_attribute *attr,
{
struct con_driver *con = dev_get_drvdata(dev);

- return snprintf(buf, PAGE_SIZE, "%s %s\n",
- (con->flag & CON_DRIVER_FLAG_MODULE) ? "(M)" : "(S)",
- con->desc);
+ return sysfs_emit(buf, "%s %s\n", (con->flag & CON_DRIVER_FLAG_MODULE) ? "(M)" : "(S)",
+ con->desc);

}

--
1.8.3.1

2021-02-22 08:57:06

by Greg Kroah-Hartman

Subject: Re: [PATCH] vt: convert sysfs sprintf/snprintf family to sysfs_emit

On Mon, Feb 22, 2021 at 04:48:49PM +0800, Jiapeng Chong wrote:
> Fix the following coccicheck warning:
>
> ./drivers/tty/vt/vt.c:3909:8-16: WARNING: use scnprintf or sprintf.
> ./drivers/tty/vt/vt.c:3917:8-16: WARNING: use scnprintf or sprintf

Why?

You say what you did, but there is no justification for why this is
required in the tree.

>
> Reported-by: Abaci Robot<[email protected]>

You forgot a ' '.

> Signed-off-by: Jiapeng Chong <[email protected]>
> ---
> drivers/tty/vt/vt.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/tty/vt/vt.c b/drivers/tty/vt/vt.c
> index 284b072..cdf8132 100644
> --- a/drivers/tty/vt/vt.c
> +++ b/drivers/tty/vt/vt.c
> @@ -3906,7 +3906,7 @@ static ssize_t show_bind(struct device *dev, struct device_attribute *attr,
> bind = con_is_bound(con->con);
> console_unlock();
>
> - return snprintf(buf, PAGE_SIZE, "%i\n", bind);
> + return sysfs_emit(buf, "%i\n", bind);
> }
>
> static ssize_t show_name(struct device *dev, struct device_attribute *attr,
> @@ -3914,9 +3914,8 @@ static ssize_t show_name(struct device *dev, struct device_attribute *attr,
> {
> struct con_driver *con = dev_get_drvdata(dev);
>
> - return snprintf(buf, PAGE_SIZE, "%s %s\n",
> - (con->flag & CON_DRIVER_FLAG_MODULE) ? "(M)" : "(S)",
> - con->desc);
> + return sysfs_emit(buf, "%s %s\n", (con->flag & CON_DRIVER_FLAG_MODULE) ? "(M)" : "(S)",
> + con->desc);

Why make the line longer now? Can't this be a 1 line change here?

And why is this needed?

thanks,

greg k-h