2021-03-11 06:15:29

by Bhaskar Chowdhury

[permalink] [raw]
Subject: [PATCH] ia64: kernel: Few typos fixed in the file fsys.S


Mundane spelling fixes.

Signed-off-by: Bhaskar Chowdhury <[email protected]>
---
arch/ia64/kernel/fsys.S | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/ia64/kernel/fsys.S b/arch/ia64/kernel/fsys.S
index 0750a716adc7..2094f3249019 100644
--- a/arch/ia64/kernel/fsys.S
+++ b/arch/ia64/kernel/fsys.S
@@ -172,7 +172,7 @@ ENTRY(fsys_gettimeofday)
// r25 = itc_lastcycle value
// r26 = address clocksource cycle_last
// r27 = (not used)
- // r28 = sequence number at the beginning of critcal section
+ // r28 = sequence number at the beginning of critical section
// r29 = address of itc_jitter
// r30 = time processing flags / memory address
// r31 = pointer to result
@@ -432,7 +432,7 @@ GLOBAL_ENTRY(fsys_bubble_down)
* - r29: psr
*
* We used to clear some PSR bits here but that requires slow
- * serialization. Fortuntely, that isn't really necessary.
+ * serialization. Fortunately, that isn't really necessary.
* The rationale is as follows: we used to clear bits
* ~PSR_PRESERVED_BITS in PSR.L. Since
* PSR_PRESERVED_BITS==PSR.{UP,MFL,MFH,PK,DT,PP,SP,RT,IC}, we
--
2.26.2


2021-03-11 06:19:25

by Randy Dunlap

[permalink] [raw]
Subject: Re: [PATCH] ia64: kernel: Few typos fixed in the file fsys.S

On 3/10/21 10:10 PM, Bhaskar Chowdhury wrote:
>
> Mundane spelling fixes.
>
> Signed-off-by: Bhaskar Chowdhury <[email protected]>

Acked-by: Randy Dunlap <[email protected]>

but no maintainer Cc:ed to pick it up...

> ---
> arch/ia64/kernel/fsys.S | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/ia64/kernel/fsys.S b/arch/ia64/kernel/fsys.S
> index 0750a716adc7..2094f3249019 100644
> --- a/arch/ia64/kernel/fsys.S
> +++ b/arch/ia64/kernel/fsys.S
> @@ -172,7 +172,7 @@ ENTRY(fsys_gettimeofday)
> // r25 = itc_lastcycle value
> // r26 = address clocksource cycle_last
> // r27 = (not used)
> - // r28 = sequence number at the beginning of critcal section
> + // r28 = sequence number at the beginning of critical section
> // r29 = address of itc_jitter
> // r30 = time processing flags / memory address
> // r31 = pointer to result
> @@ -432,7 +432,7 @@ GLOBAL_ENTRY(fsys_bubble_down)
> * - r29: psr
> *
> * We used to clear some PSR bits here but that requires slow
> - * serialization. Fortuntely, that isn't really necessary.
> + * serialization. Fortunately, that isn't really necessary.
> * The rationale is as follows: we used to clear bits
> * ~PSR_PRESERVED_BITS in PSR.L. Since
> * PSR_PRESERVED_BITS==PSR.{UP,MFL,MFH,PK,DT,PP,SP,RT,IC}, we
> --


--
~Randy

Subject: Re: [PATCH] ia64: kernel: Few typos fixed in the file fsys.S

Hi!

On 3/11/21 7:15 AM, Randy Dunlap wrote:
> On 3/10/21 10:10 PM, Bhaskar Chowdhury wrote:
>>
>> Mundane spelling fixes.
>>
>> Signed-off-by: Bhaskar Chowdhury <[email protected]>
>
> Acked-by: Randy Dunlap <[email protected]>
>
> but no maintainer Cc:ed to pick it up...

I guess Andrew's tree will just work fine in this case?

Adrian

--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer - [email protected]
`. `' Freie Universitaet Berlin - [email protected]
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913

2021-03-11 06:23:53

by Randy Dunlap

[permalink] [raw]
Subject: Re: [PATCH] ia64: kernel: Few typos fixed in the file fsys.S

On 3/10/21 10:17 PM, John Paul Adrian Glaubitz wrote:
> Hi!
>
> On 3/11/21 7:15 AM, Randy Dunlap wrote:
>> On 3/10/21 10:10 PM, Bhaskar Chowdhury wrote:
>>>
>>> Mundane spelling fixes.
>>>
>>> Signed-off-by: Bhaskar Chowdhury <[email protected]>
>>
>> Acked-by: Randy Dunlap <[email protected]>
>>
>> but no maintainer Cc:ed to pick it up...
>
> I guess Andrew's tree will just work fine in this case?

Sure, it could.

--
~Randy

2021-03-11 06:26:41

by Bhaskar Chowdhury

[permalink] [raw]
Subject: Re: [PATCH] ia64: kernel: Few typos fixed in the file fsys.S

On 22:15 Wed 10 Mar 2021, Randy Dunlap wrote:
>On 3/10/21 10:10 PM, Bhaskar Chowdhury wrote:
>>
>> Mundane spelling fixes.
>>
>> Signed-off-by: Bhaskar Chowdhury <[email protected]>
>
>Acked-by: Randy Dunlap <[email protected]>
>
>but no maintainer Cc:ed to pick it up...
>
I have seen "maintainer less" files and you have pointed out that too in the
past...what do I do Randy??? Should run "git blame" to find out ,who touch the file and
include those mail??? I don't think that would be good idea.

Bemused!! Throw some light.
>> ---
>> arch/ia64/kernel/fsys.S | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/ia64/kernel/fsys.S b/arch/ia64/kernel/fsys.S
>> index 0750a716adc7..2094f3249019 100644
>> --- a/arch/ia64/kernel/fsys.S
>> +++ b/arch/ia64/kernel/fsys.S
>> @@ -172,7 +172,7 @@ ENTRY(fsys_gettimeofday)
>> // r25 = itc_lastcycle value
>> // r26 = address clocksource cycle_last
>> // r27 = (not used)
>> - // r28 = sequence number at the beginning of critcal section
>> + // r28 = sequence number at the beginning of critical section
>> // r29 = address of itc_jitter
>> // r30 = time processing flags / memory address
>> // r31 = pointer to result
>> @@ -432,7 +432,7 @@ GLOBAL_ENTRY(fsys_bubble_down)
>> * - r29: psr
>> *
>> * We used to clear some PSR bits here but that requires slow
>> - * serialization. Fortuntely, that isn't really necessary.
>> + * serialization. Fortunately, that isn't really necessary.
>> * The rationale is as follows: we used to clear bits
>> * ~PSR_PRESERVED_BITS in PSR.L. Since
>> * PSR_PRESERVED_BITS==PSR.{UP,MFL,MFH,PK,DT,PP,SP,RT,IC}, we
>> --
>
>
>--
>~Randy
>


Attachments:
(No filename) (1.70 kB)
signature.asc (499.00 B)
Download all attachments

2021-03-11 06:31:58

by Randy Dunlap

[permalink] [raw]
Subject: Re: [PATCH] ia64: kernel: Few typos fixed in the file fsys.S

On 3/10/21 10:24 PM, Bhaskar Chowdhury wrote:
> On 22:15 Wed 10 Mar 2021, Randy Dunlap wrote:
>> On 3/10/21 10:10 PM, Bhaskar Chowdhury wrote:
>>>
>>> Mundane spelling fixes.
>>>
>>> Signed-off-by: Bhaskar Chowdhury <[email protected]>
>>
>> Acked-by: Randy Dunlap <[email protected]>
>>
>> but no maintainer Cc:ed to pick it up...
>>
> I have seen "maintainer less" files and you have pointed out that too in the
> past...what do I do Randy??? Should run "git blame" to find out ,who touch the file and
> include those mail??? I don't think that would be good idea.
>
> Bemused!! Throw some light.

Well, we know that ia64 is orphaned, so you need to find someone
to merge the patch. Andrew Morton is usually a good bet. :)

or use 'git log' <filename> to see who has been merging patches
to that file.

>>> ---
>>> ?arch/ia64/kernel/fsys.S | 4 ++--
>>> ?1 file changed, 2 insertions(+), 2 deletions(-)

--
~Randy