2021-03-11 12:08:33

by Shubhankar Kuranagatti

Subject: [PATCH] init: do_mounts.c: Fix indentation errors.

Switch and case have been aligned together, extra tab removed
Removed extra space before tab.

Signed-off-by: Shubhankar Kuranagatti <[email protected]>
---
init/do_mounts.c | 13 ++++++-------
1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/init/do_mounts.c b/init/do_mounts.c
index a78e44ee6adb..82fe66d2eb97 100644
--- a/init/do_mounts.c
+++ b/init/do_mounts.c
@@ -422,13 +422,13 @@ void __init mount_block_root(char *name, int flags)
for (p = fs_names; *p; p += strlen(p)+1) {
int err = do_mount_root(name, p, flags, root_mount_data);
switch (err) {
- case 0:
- goto out;
- case -EACCES:
- case -EINVAL:
- continue;
+ case 0:
+ goto out;
+ case -EACCES:
+ case -EINVAL:
+ continue;
}
- /*
+ /*
* Allow the user to distinguish between failed sys_open
* and bad superblock on root device.
* and give them a list of the available devices
@@ -459,7 +459,6 @@ void __init mount_block_root(char *name, int flags)
out:
put_page(page);
}
-
#ifdef CONFIG_ROOT_NFS

#define NFSROOT_TIMEOUT_MIN 5
--
2.17.1

2021-03-11 12:31:37

by Greg Kroah-Hartman

Subject: Re: [PATCH] init: do_mounts.c: Fix indentation errors.

On Thu, Mar 11, 2021 at 05:36:50PM +0530, Shubhankar Kuranagatti wrote:
> Switch and case have been aligned together, extra tab removed
> Removed extra space before tab.
>
> Signed-off-by: Shubhankar Kuranagatti <[email protected]>
> ---
> init/do_mounts.c | 13 ++++++-------
> 1 file changed, 6 insertions(+), 7 deletions(-)

For basic "clean up the code as a first patch task", please stick to the
code under drivers/staging/ and do not venture out into the "core"
kernel files as that just causes unneeded and unwanted churn.

good luck!

greg k-h