2021-03-31 03:21:37

by Chunyan Zhang

Subject: [PATCH] iommu: sprd: Fix parameter type warning

From: Chunyan Zhang <[email protected]>

The second parameter of clk_get_optional() is "const char *", so use NULL
instead of integer 0 to fix a sparse warning like:

">> drivers/iommu/sprd-iommu.c:456:42: sparse: sparse: Using plain integer as NULL pointer"

Also this patch changes to use the resource-managed variant of
clk_get_optional(), then there's no need to add clk_put() which
is missed in the current driver.

Reported-by: kernel test robot <[email protected]>
Signed-off-by: Chunyan Zhang <[email protected]>
---
drivers/iommu/sprd-iommu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iommu/sprd-iommu.c b/drivers/iommu/sprd-iommu.c
index 7100ed17dcce..371d5715cbc9 100644
--- a/drivers/iommu/sprd-iommu.c
+++ b/drivers/iommu/sprd-iommu.c
@@ -453,7 +453,7 @@ static int sprd_iommu_clk_enable(struct sprd_iommu_device *sdev)
{
struct clk *eb;

- eb = clk_get_optional(sdev->dev, 0);
+ eb = devm_clk_get_optional(sdev->dev, NULL);
if (!eb)
return 0;

--
2.25.1

2021-04-07 20:37:12

by Joerg Roedel

Subject: Re: [PATCH] iommu: sprd: Fix parameter type warning

On Wed, Mar 31, 2021 at 11:16:45AM +0800, Chunyan Zhang wrote:
> drivers/iommu/sprd-iommu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.