Clean up Check:spaces preferred around that '+' (ctx:VxV)
Reported by checkpatch
Signed-off-by: Mitali Borkar <[email protected]>
---
drivers/staging/rtl8712/wlan_bssdef.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index b54ccaacc527..ec3749813728 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -176,7 +176,7 @@ struct NDIS_802_11_WEP {
#define MIC_CHECK_TIME 60000000
#ifndef Ndis802_11APMode
-#define Ndis802_11APMode (Ndis802_11InfrastructureMax+1)
+#define Ndis802_11APMode (Ndis802_11InfrastructureMax + 1)
#endif
struct wlan_network {
--
2.30.2
The subject line should be in the imperative, so "add" instead of "added".
On Thu, 8 Apr 2021, Mitali Borkar wrote:
> Clean up Check:spaces preferred around that '+' (ctx:VxV)
> Reported by checkpatch
Please try to rephrase to explain what you did and why. "Clean up" kind
of states what the goal is, but your opinion about what is a clean up
might be different than someone else's. It's also not necessary to cite
the checkpatch warning exactly.
julia
>
> Signed-off-by: Mitali Borkar <[email protected]>
> ---
> drivers/staging/rtl8712/wlan_bssdef.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
> index b54ccaacc527..ec3749813728 100644
> --- a/drivers/staging/rtl8712/wlan_bssdef.h
> +++ b/drivers/staging/rtl8712/wlan_bssdef.h
> @@ -176,7 +176,7 @@ struct NDIS_802_11_WEP {
> #define MIC_CHECK_TIME 60000000
>
> #ifndef Ndis802_11APMode
> -#define Ndis802_11APMode (Ndis802_11InfrastructureMax+1)
> +#define Ndis802_11APMode (Ndis802_11InfrastructureMax + 1)
> #endif
>
> struct wlan_network {
> --
> 2.30.2
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/YG690ZIRdCEcjoM6%40kali.
>
On Thu, Apr 08, 2021 at 10:30:09AM +0200, Julia Lawall wrote:
> The subject line should be in the imperative, so "add" instead of "added".
>
Ok Ma'am
> On Thu, 8 Apr 2021, Mitali Borkar wrote:
>
> > Clean up Check:spaces preferred around that '+' (ctx:VxV)
> > Reported by checkpatch
>
> Please try to rephrase to explain what you did and why. "Clean up" kind
> of states what the goal is, but your opinion about what is a clean up
> might be different than someone else's. It's also not necessary to cite
> the checkpatch warning exactly.
>
OKay Ma'am, will rewrite the appopriate commit message. May I know while
resending this patch, what should I write in subject description,
RESEND PATCH or PATCH v2
Thanks
Mitali
> julia
>
> >
> > Signed-off-by: Mitali Borkar <[email protected]>
> > ---
> > drivers/staging/rtl8712/wlan_bssdef.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
> > index b54ccaacc527..ec3749813728 100644
> > --- a/drivers/staging/rtl8712/wlan_bssdef.h
> > +++ b/drivers/staging/rtl8712/wlan_bssdef.h
> > @@ -176,7 +176,7 @@ struct NDIS_802_11_WEP {
> > #define MIC_CHECK_TIME 60000000
> >
> > #ifndef Ndis802_11APMode
> > -#define Ndis802_11APMode (Ndis802_11InfrastructureMax+1)
> > +#define Ndis802_11APMode (Ndis802_11InfrastructureMax + 1)
> > #endif
> >
> > struct wlan_network {
> > --
> > 2.30.2
> >
> > --
> > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
> > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/YG690ZIRdCEcjoM6%40kali.
> >
On Thu, Apr 08, 2021 at 04:55:45PM +0530, Mitali Borkar wrote:
> On Thu, Apr 08, 2021 at 10:30:09AM +0200, Julia Lawall wrote:
> > The subject line should be in the imperative, so "add" instead of "added".
> >
> Ok Ma'am
> > On Thu, 8 Apr 2021, Mitali Borkar wrote:
> >
> > > Clean up Check:spaces preferred around that '+' (ctx:VxV)
> > > Reported by checkpatch
> >
> > Please try to rephrase to explain what you did and why. "Clean up" kind
> > of states what the goal is, but your opinion about what is a clean up
> > might be different than someone else's. It's also not necessary to cite
> > the checkpatch warning exactly.
> >
> OKay Ma'am, will rewrite the appopriate commit message. May I know while
> resending this patch, what should I write in subject description,
> RESEND PATCH or PATCH v2
"RESEND" is only ok if the patch and changelog text is identical to the
previous version and something got lost so it needed to be resent.
I do not think that is the case here.
thanks,
greg k-h