2021-03-29 11:01:44

by Heikki Krogerus

Subject: [PATCH 03/12] ARM: omap1: osk: Constify the software node

Additional device properties are always just a part of a
software fwnode. If the device properties are constant, the
software node can also be constant.

Signed-off-by: Heikki Krogerus <[email protected]>
Cc: Aaro Koskinen <[email protected]>
Cc: Tony Lindgren <[email protected]>
---
arch/arm/mach-omap1/board-osk.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/arch/arm/mach-omap1/board-osk.c b/arch/arm/mach-omap1/board-osk.c
index 0a4c9b0b13b0c..e18b6f13300eb 100644
--- a/arch/arm/mach-omap1/board-osk.c
+++ b/arch/arm/mach-omap1/board-osk.c
@@ -332,11 +332,15 @@ static const struct property_entry mistral_at24_properties[] = {
{ }
};

+static const struct software_node mistral_at24_node = {
+ .properties = mistral_at24_properties,
+};
+
static struct i2c_board_info __initdata mistral_i2c_board_info[] = {
{
/* NOTE: powered from LCD supply */
I2C_BOARD_INFO("24c04", 0x50),
- .properties = mistral_at24_properties,
+ .swnode = &mistral_at24_node,
},
/* TODO when driver support is ready:
* - optionally ov9640 camera sensor at 0x30
--
2.30.2

2021-03-31 06:16:34

by Tony Lindgren

Subject: Re: [PATCH 03/12] ARM: omap1: osk: Constify the software node

* Heikki Krogerus <[email protected]> [210329 10:51]:
> Additional device properties are always just a part of a
> software fwnode. If the device properties are constant, the
> software node can also be constant.
>
> Signed-off-by: Heikki Krogerus <[email protected]>
> Cc: Aaro Koskinen <[email protected]>
> Cc: Tony Lindgren <[email protected]>

Probably best to merge this via the rest of the series:

Acked-by: Tony Lindgren <[email protected]>

> ---
> arch/arm/mach-omap1/board-osk.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-omap1/board-osk.c b/arch/arm/mach-omap1/board-osk.c
> index 0a4c9b0b13b0c..e18b6f13300eb 100644
> --- a/arch/arm/mach-omap1/board-osk.c
> +++ b/arch/arm/mach-omap1/board-osk.c
> @@ -332,11 +332,15 @@ static const struct property_entry mistral_at24_properties[] = {
> { }
> };
>
> +static const struct software_node mistral_at24_node = {
> + .properties = mistral_at24_properties,
> +};
> +
> static struct i2c_board_info __initdata mistral_i2c_board_info[] = {
> {
> /* NOTE: powered from LCD supply */
> I2C_BOARD_INFO("24c04", 0x50),
> - .properties = mistral_at24_properties,
> + .swnode = &mistral_at24_node,
> },
> /* TODO when driver support is ready:
> * - optionally ov9640 camera sensor at 0x30
> --
> 2.30.2
>