2021-03-05 09:09:11

by Gustavo A. R. Silva

Subject: [PATCH RESEND][next] sctp: Fix fall-through warnings for Clang

In preparation to enable -Wimplicit-fallthrough for Clang, fix a couple
of warnings by explicitly adding a break statement and replacing a
comment with a goto statement instead of letting the code fall through
to the next case.

Link: https://github.com/KSPP/linux/issues/115
Signed-off-by: Gustavo A. R. Silva <[email protected]>
---
net/sctp/input.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/net/sctp/input.c b/net/sctp/input.c
index d508f6f3dd08..5ceaf75105ba 100644
--- a/net/sctp/input.c
+++ b/net/sctp/input.c
@@ -633,7 +633,7 @@ int sctp_v4_err(struct sk_buff *skb, __u32 info)
break;
case ICMP_REDIRECT:
sctp_icmp_redirect(sk, transport, skb);
- /* Fall through to out_unlock. */
+ goto out_unlock;
default:
goto out_unlock;
}
@@ -1236,6 +1236,7 @@ static struct sctp_association *__sctp_rcv_walk_lookup(struct net *net,
net, ch, laddr,
sctp_hdr(skb)->source,
transportp);
+ break;
default:
break;
}
--
2.27.0

2021-04-20 20:12:19

by Gustavo A. R. Silva

Subject: Re: [PATCH RESEND][next] sctp: Fix fall-through warnings for Clang

Hi all,

Friendly ping: who can take this, please?

Thanks
--
Gustavo

On 3/5/21 03:07, Gustavo A. R. Silva wrote:
> In preparation to enable -Wimplicit-fallthrough for Clang, fix a couple
> of warnings by explicitly adding a break statement and replacing a
> comment with a goto statement instead of letting the code fall through
> to the next case.
>
> Link: https://github.com/KSPP/linux/issues/115
> Signed-off-by: Gustavo A. R. Silva <[email protected]>
> ---
> net/sctp/input.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/net/sctp/input.c b/net/sctp/input.c
> index d508f6f3dd08..5ceaf75105ba 100644
> --- a/net/sctp/input.c
> +++ b/net/sctp/input.c
> @@ -633,7 +633,7 @@ int sctp_v4_err(struct sk_buff *skb, __u32 info)
> break;
> case ICMP_REDIRECT:
> sctp_icmp_redirect(sk, transport, skb);
> - /* Fall through to out_unlock. */
> + goto out_unlock;
> default:
> goto out_unlock;
> }
> @@ -1236,6 +1236,7 @@ static struct sctp_association *__sctp_rcv_walk_lookup(struct net *net,
> net, ch, laddr,
> sctp_hdr(skb)->source,
> transportp);
> + break;
> default:
> break;
> }
>

2021-04-20 20:22:03

by Marcelo Ricardo Leitner

Subject: Re: [PATCH RESEND][next] sctp: Fix fall-through warnings for Clang

On Tue, Apr 20, 2021 at 03:09:24PM -0500, Gustavo A. R. Silva wrote:
> Hi all,
>
> Friendly ping: who can take this, please?

It would go via net/net-next tree, but I can't find this one on
patchwork. Just the previous version.

http://patchwork.ozlabs.org/project/netdev/list/?series=&submitter=&state=*&q=sctp%3A+Fix+fall-through+warnings+for+Clang&archive=both&delegate=

I can, however, find it in the archives.

https://lore.kernel.org/netdev/20210305090717.GA139387%40embeddedor/T/

Dave and Jakub will know better.

Marcelo

2021-05-19 09:53:54

by Gustavo A. R. Silva

Subject: Re: [PATCH RESEND][next] sctp: Fix fall-through warnings for Clang

Thanks, Marcelo.

I'm taking this in my -next[1] branch for v5.14.

Thanks
--
Gustavo

[1] https://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git/log/?h=for-next/kspp

On 4/20/21 15:19, Marcelo Ricardo Leitner wrote:
> On Tue, Apr 20, 2021 at 03:09:24PM -0500, Gustavo A. R. Silva wrote:
>> Hi all,
>>
>> Friendly ping: who can take this, please?
>
> It would go via net/net-next tree, but I can't find this one on
> patchwork. Just the previous version.
>
> http://patchwork.ozlabs.org/project/netdev/list/?series=&submitter=&state=*&q=sctp%3A+Fix+fall-through+warnings+for+Clang&archive=both&delegate=
>
> I can, however, find it in the archives.
>
> https://lore.kernel.org/netdev/20210305090717.GA139387%40embeddedor/T/
>
> Dave and Jakub will know better.
>
> Marcelo
>