2021-04-13 18:33:44

by Mitali Borkar

Subject: [PATCH v3] staging: media: meson: vdec: declare u32 as static const

Declared 32 bit unsigned int as static constant inside a function and
replaced u32[] {x,y} as canvas3, canvas4 in codec_h264.c
This indicates the value of canvas indexes will remain constant throughout execution.

Reported-by: kernel test robot <[email protected]>
Signed-off-by: Mitali Borkar <[email protected]>
---
Changes from v2:- Rebased this patch and made changes against mainline code
Changes from v1:- Rectified mistake by declaring u32 as static const
properly as static const u32 canvas'x'[]

drivers/staging/media/meson/vdec/codec_h264.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/media/meson/vdec/codec_h264.c b/drivers/staging/media/meson/vdec/codec_h264.c
index c61128fc4bb9..80141b89a9f6 100644
--- a/drivers/staging/media/meson/vdec/codec_h264.c
+++ b/drivers/staging/media/meson/vdec/codec_h264.c
@@ -287,10 +287,10 @@ static void codec_h264_resume(struct amvdec_session *sess)
struct amvdec_core *core = sess->core;
struct codec_h264 *h264 = sess->priv;
u32 mb_width, mb_height, mb_total;
+ static const u32 canvas3[] = { ANCO_CANVAS_ADDR, 0 };
+ static const u32 canvas4[] = { 24, 0 };

- amvdec_set_canvases(sess,
- (u32[]){ ANC0_CANVAS_ADDR, 0 },
- (u32[]){ 24, 0 });
+ amvdec_set_canvases(sess, canvas3, canvas4);

dev_dbg(core->dev, "max_refs = %u; actual_dpb_size = %u\n",
h264->max_refs, sess->num_dst_bufs);
--
2.30.2

2021-04-13 20:57:39

by Hans Verkuil

Subject: Re: [PATCH v3] staging: media: meson: vdec: declare u32 as static const

On 13/04/2021 16:11, Mitali Borkar wrote:
> Declared 32 bit unsigned int as static constant inside a function and
> replaced u32[] {x,y} as canvas3, canvas4 in codec_h264.c
> This indicates the value of canvas indexes will remain constant throughout execution.

checkpatch.pl output:

WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#9:
This indicates the value of canvas indexes will remain constant throughout execution.

Regards,

Hans

>
> Reported-by: kernel test robot <[email protected]>
> Signed-off-by: Mitali Borkar <[email protected]>
> ---
> Changes from v2:- Rebased this patch and made changes against mainline code
> Changes from v1:- Rectified mistake by declaring u32 as static const
> properly as static const u32 canvas'x'[]
>
> drivers/staging/media/meson/vdec/codec_h264.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/media/meson/vdec/codec_h264.c b/drivers/staging/media/meson/vdec/codec_h264.c
> index c61128fc4bb9..80141b89a9f6 100644
> --- a/drivers/staging/media/meson/vdec/codec_h264.c
> +++ b/drivers/staging/media/meson/vdec/codec_h264.c
> @@ -287,10 +287,10 @@ static void codec_h264_resume(struct amvdec_session *sess)
> struct amvdec_core *core = sess->core;
> struct codec_h264 *h264 = sess->priv;
> u32 mb_width, mb_height, mb_total;
> + static const u32 canvas3[] = { ANCO_CANVAS_ADDR, 0 };
> + static const u32 canvas4[] = { 24, 0 };
>
> - amvdec_set_canvases(sess,
> - (u32[]){ ANC0_CANVAS_ADDR, 0 },
> - (u32[]){ 24, 0 });
> + amvdec_set_canvases(sess, canvas3, canvas4);
>
> dev_dbg(core->dev, "max_refs = %u; actual_dpb_size = %u\n",
> h264->max_refs, sess->num_dst_bufs);
>