2021-04-15 08:35:13

by Jiapeng Chong

Subject: [PATCH] PCI: dwc: remove unused function

Fix the following clang warning:

drivers/pci/controller/dwc/pcie-intel-gw.c:84:19: warning: unused
function 'pcie_app_rd' [-Wunused-function].

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
drivers/pci/controller/dwc/pcie-intel-gw.c | 5 -----
1 file changed, 5 deletions(-)

diff --git a/drivers/pci/controller/dwc/pcie-intel-gw.c b/drivers/pci/controller/dwc/pcie-intel-gw.c
index 0cedd1f..f89a7d2 100644
--- a/drivers/pci/controller/dwc/pcie-intel-gw.c
+++ b/drivers/pci/controller/dwc/pcie-intel-gw.c
@@ -81,11 +81,6 @@ static void pcie_update_bits(void __iomem *base, u32 ofs, u32 mask, u32 val)
writel(val, base + ofs);
}

-static inline u32 pcie_app_rd(struct intel_pcie_port *lpp, u32 ofs)
-{
- return readl(lpp->app_base + ofs);
-}
-
static inline void pcie_app_wr(struct intel_pcie_port *lpp, u32 ofs, u32 val)
{
writel(val, lpp->app_base + ofs);
--
1.8.3.1

2021-04-15 13:34:07

by Krzysztof Wilczyński

Subject: Re: [PATCH] PCI: dwc: remove unused function

Hi,

> Fix the following clang warning:
>
> drivers/pci/controller/dwc/pcie-intel-gw.c:84:19: warning: unused
> function 'pcie_app_rd' [-Wunused-function].
[...]

Nice catch! Thank you.

Reviewed-by: Krzysztof Wilczyński <[email protected]>

By the way, next time capitalise the subject line.

Krzysztof

2021-04-15 15:19:18

by Lorenzo Pieralisi

Subject: Re: [PATCH] PCI: dwc: remove unused function

On Thu, 15 Apr 2021 16:32:57 +0800, Jiapeng Chong wrote:
> Fix the following clang warning:
>
> drivers/pci/controller/dwc/pcie-intel-gw.c:84:19: warning: unused
> function 'pcie_app_rd' [-Wunused-function].

Applied to pci/dwc, thanks!

[1/1] PCI: dwc/intel-gw: Remove unused function
https://git.kernel.org/lpieralisi/pci/c/9534286be3

Thanks,
Lorenzo