2021-05-05 06:57:23

by Satya Priya

[permalink] [raw]
Subject: [PATCH V4 7/8] arm64: dts: qcom: sc7280: Add channel nodes for sc7280-idp

Add channel nodes for the on die temperatures of PMICS
pmk8350, pm8350, pmr735a and pmr735b.

Signed-off-by: satya priya <[email protected]>
---
arch/arm64/boot/dts/qcom/sc7280-idp.dts | 30 ++++++++++++++++++++++++++++++
1 file changed, 30 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dts b/arch/arm64/boot/dts/qcom/sc7280-idp.dts
index 54d2cb3..02a14fc 100644
--- a/arch/arm64/boot/dts/qcom/sc7280-idp.dts
+++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dts
@@ -7,6 +7,10 @@

/dts-v1/;

+#include <dt-bindings/iio/qcom,spmi-adc7-pmr735a.h>
+#include <dt-bindings/iio/qcom,spmi-adc7-pmr735b.h>
+#include <dt-bindings/iio/qcom,spmi-adc7-pm8350.h>
+#include <dt-bindings/iio/qcom,spmi-adc7-pmk8350.h>
#include "sc7280.dtsi"

/ {
@@ -234,6 +238,32 @@
};
};

+&pmk8350_vadc {
+ pm8350_die_temp {
+ reg = <PM8350_ADC7_DIE_TEMP>;
+ label = "pm8350_die_temp";
+ qcom,pre-scaling = <1 1>;
+ };
+
+ pmk8350_die_temp {
+ reg = <PMK8350_ADC7_DIE_TEMP>;
+ label = "pmk8350_die_temp";
+ qcom,pre-scaling = <1 1>;
+ };
+
+ pmr735a_die_temp {
+ reg = <PMR735A_ADC7_DIE_TEMP>;
+ label = "pmr735a_die_temp";
+ qcom,pre-scaling = <1 1>;
+ };
+
+ pmr735b_die_temp {
+ reg = <PMR735B_ADC7_DIE_TEMP>;
+ label = "pmr735b_die_temp";
+ qcom,pre-scaling = <1 1>;
+ };
+};
+
&qupv3_id_0 {
status = "okay";
};
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation


2021-05-05 19:31:05

by Matthias Kaehlcke

[permalink] [raw]
Subject: Re: [PATCH V4 7/8] arm64: dts: qcom: sc7280: Add channel nodes for sc7280-idp

On Wed, May 05, 2021 at 12:25:25PM +0530, satya priya wrote:

> Subject: arm64: dts: qcom: sc7280: Add channel nodes for sc7280-idp

nit: just 'channel nodes' is a bit vague. In case you respin maybe
change it to something like 'Add ADC channel nodes for PMIC
temperatures to sc7280-idp'

In any case it doesn't seem worth to respin just for this.

>
> Add channel nodes for the on die temperatures of PMICS
> pmk8350, pm8350, pmr735a and pmr735b.
>
> Signed-off-by: satya priya <[email protected]>

Reviewed-by: Matthias Kaehlcke <[email protected]>

2021-05-17 06:25:59

by Satya Priya

[permalink] [raw]
Subject: Re: [PATCH V4 7/8] arm64: dts: qcom: sc7280: Add channel nodes for sc7280-idp

On 2021-05-05 20:16, Matthias Kaehlcke wrote:
> On Wed, May 05, 2021 at 12:25:25PM +0530, satya priya wrote:
>
>> Subject: arm64: dts: qcom: sc7280: Add channel nodes for sc7280-idp
>
> nit: just 'channel nodes' is a bit vague. In case you respin maybe
> change it to something like 'Add ADC channel nodes for PMIC
> temperatures to sc7280-idp'
>

Okay will change it and resend v4.

> In any case it doesn't seem worth to respin just for this.
>
>>
>> Add channel nodes for the on die temperatures of PMICS
>> pmk8350, pm8350, pmr735a and pmr735b.
>>
>> Signed-off-by: satya priya <[email protected]>
>
> Reviewed-by: Matthias Kaehlcke <[email protected]>