2021-05-09 09:13:17

by Mike Rapoport

Subject: [PATCH 2/2] openrisc: mm/init.c: remove unused variable 'end' in paging_init()

From: Mike Rapoport <[email protected]>

A build with W=1 enabled produces the following warning:

CC arch/openrisc/mm/init.o
arch/openrisc/mm/init.c: In function 'paging_init':
arch/openrisc/mm/init.c:131:16: warning: variable 'end' set but not used [-Wunused-but-set-variable]
131 | unsigned long end;
| ^~~

Remove the unused variable 'end'.

Signed-off-by: Mike Rapoport <[email protected]>
---
arch/openrisc/mm/init.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/arch/openrisc/mm/init.c b/arch/openrisc/mm/init.c
index f3fa02b8838a..6e38ec96cab8 100644
--- a/arch/openrisc/mm/init.c
+++ b/arch/openrisc/mm/init.c
@@ -128,7 +128,6 @@ void __init paging_init(void)
{
extern void tlb_init(void);

- unsigned long end;
int i;

printk(KERN_INFO "Setting up paging and PTEs.\n");
@@ -144,8 +143,6 @@ void __init paging_init(void)
*/
current_pgd[smp_processor_id()] = init_mm.pgd;

- end = (unsigned long)__va(max_low_pfn * PAGE_SIZE);
-
map_ram();

zone_sizes_init();
--
2.28.0

2021-05-09 21:19:29

by Stafford Horne

Subject: Re: [PATCH 2/2] openrisc: mm/init.c: remove unused variable 'end' in paging_init()

On Sun, May 09, 2021 at 12:11:03PM +0300, Mike Rapoport wrote:
> From: Mike Rapoport <[email protected]>
>
> A build with W=1 enabled produces the following warning:
>
> CC arch/openrisc/mm/init.o
> arch/openrisc/mm/init.c: In function 'paging_init':
> arch/openrisc/mm/init.c:131:16: warning: variable 'end' set but not used [-Wunused-but-set-variable]
> 131 | unsigned long end;
> | ^~~
>
> Remove the unused variable 'end'.
>
> Signed-off-by: Mike Rapoport <[email protected]>
> ---
> arch/openrisc/mm/init.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/arch/openrisc/mm/init.c b/arch/openrisc/mm/init.c
> index f3fa02b8838a..6e38ec96cab8 100644
> --- a/arch/openrisc/mm/init.c
> +++ b/arch/openrisc/mm/init.c
> @@ -128,7 +128,6 @@ void __init paging_init(void)
> {
> extern void tlb_init(void);
>
> - unsigned long end;
> int i;
>
> printk(KERN_INFO "Setting up paging and PTEs.\n");
> @@ -144,8 +143,6 @@ void __init paging_init(void)
> */
> current_pgd[smp_processor_id()] = init_mm.pgd;
>
> - end = (unsigned long)__va(max_low_pfn * PAGE_SIZE);
> -
> map_ram();
>
> zone_sizes_init();

Thanks, I will queue this in the openrisc fixes queue.

-Stafford