2021-04-26 00:46:07

by Robin Gong

Subject: [PATCH v3] dmaengine: fsl-qdma: check dma_set_mask return value

For fix below warning reported by static code analysis tool like Coverity
from Synopsys:

'CID 12285639 (#1 of 2): Unchecked return value (CHECKED_RETURN)'

Signed-off-by: Robin Gong <[email protected]>
---
drivers/dma/fsl-qdma.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/dma/fsl-qdma.c b/drivers/dma/fsl-qdma.c
index ed2ab46..045ead4 100644
--- a/drivers/dma/fsl-qdma.c
+++ b/drivers/dma/fsl-qdma.c
@@ -1235,7 +1235,11 @@ static int fsl_qdma_probe(struct platform_device *pdev)
fsl_qdma->dma_dev.device_synchronize = fsl_qdma_synchronize;
fsl_qdma->dma_dev.device_terminate_all = fsl_qdma_terminate_all;

- dma_set_mask(&pdev->dev, DMA_BIT_MASK(40));
+ ret = dma_set_mask(&pdev->dev, DMA_BIT_MASK(40));
+ if (ret) {
+ dev_err(&pdev->dev, "dma_set_mask failure.\n");
+ return ret;
+ }

platform_set_drvdata(pdev, fsl_qdma);

--
2.7.4

2021-05-10 14:32:23

by Vinod Koul

Subject: Re: [PATCH v3] dmaengine: fsl-qdma: check dma_set_mask return value

On 26-04-21, 16:59, Robin Gong wrote:
> For fix below warning reported by static code analysis tool like Coverity
> from Synopsys:
>
> 'CID 12285639 (#1 of 2): Unchecked return value (CHECKED_RETURN)'

This should be:
Addresses-Coverity-ID: 12285639 ("Unchecked return value")

I have fixed that up and applied
>
> Signed-off-by: Robin Gong <[email protected]>
> ---
> drivers/dma/fsl-qdma.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/dma/fsl-qdma.c b/drivers/dma/fsl-qdma.c
> index ed2ab46..045ead4 100644
> --- a/drivers/dma/fsl-qdma.c
> +++ b/drivers/dma/fsl-qdma.c
> @@ -1235,7 +1235,11 @@ static int fsl_qdma_probe(struct platform_device *pdev)
> fsl_qdma->dma_dev.device_synchronize = fsl_qdma_synchronize;
> fsl_qdma->dma_dev.device_terminate_all = fsl_qdma_terminate_all;
>
> - dma_set_mask(&pdev->dev, DMA_BIT_MASK(40));
> + ret = dma_set_mask(&pdev->dev, DMA_BIT_MASK(40));
> + if (ret) {
> + dev_err(&pdev->dev, "dma_set_mask failure.\n");
> + return ret;
> + }
>
> platform_set_drvdata(pdev, fsl_qdma);
>
> --
> 2.7.4

--
~Vinod