2021-05-08 08:40:50

by Oded Gabbay

[permalink] [raw]
Subject: [git pull] habanalabs fixes for 5.13-rc2

Hi Greg,

This pull request contains a number of important fixes for 5.13-rc2.
Mainly fixes to support our new F/W with enhanced security features,
but also additional bugs.
See details in the tag message below.

Thanks,
Oded

The following changes since commit a48b0872e69428d3d02994dcfad3519f01def7fa:

Merge branch 'akpm' (patches from Andrew) (2021-05-07 00:34:51 -0700)

are available in the Git repository at:

https://git.kernel.org/pub/scm/linux/kernel/git/ogabbay/linux.git tags/misc-habanalabs-fixes-2021-05-08

for you to fetch changes up to 115726c5d312b462c9d9931ea42becdfa838a076:

habanalabs/gaudi: Fix a potential use after free in gaudi_memset_device_memory (2021-05-08 11:36:07 +0300)

----------------------------------------------------------------
This tag contains the following fixes for 5.13-rc2:

- Expose PLL information per ASIC. This also fixes some casting warnings.
- Skip reading further firmware errors in case PCI link is down.
- Security firmware error should be handled as error and not warning.
- Allow user to ignore firmware errors.
- Fix bug in timeout calculation when waiting for interrupt of CS.
- Fix bug of potential use-after-free.

----------------------------------------------------------------
Bharat Jauhari (1):
habanalabs: expose ASIC specific PLL index

Lv Yunlong (1):
habanalabs/gaudi: Fix a potential use after free in gaudi_memset_device_memory

Oded Gabbay (3):
habanalabs: skip reading f/w errors on bad status
habanalabs: change error level of security not ready
habanalabs: ignore f/w status error

Ofir Bitton (1):
habanalabs: wait for interrupt wrong timeout calculation

.../misc/habanalabs/common/command_submission.c | 2 +-
drivers/misc/habanalabs/common/firmware_if.c | 53 +++++++++++--------
drivers/misc/habanalabs/common/habanalabs.h | 23 ++++++---
drivers/misc/habanalabs/common/habanalabs_drv.c | 7 +++
drivers/misc/habanalabs/common/sysfs.c | 4 +-
drivers/misc/habanalabs/gaudi/gaudi.c | 59 +++++++++-------------
drivers/misc/habanalabs/gaudi/gaudi_hwmgr.c | 12 ++---
drivers/misc/habanalabs/goya/goya.c | 47 +++++++----------
drivers/misc/habanalabs/goya/goya_hwmgr.c | 40 +++++++--------
include/uapi/misc/habanalabs.h | 33 ++++++++++++
10 files changed, 156 insertions(+), 124 deletions(-)


2021-05-08 08:43:33

by Greg KH

[permalink] [raw]
Subject: Re: [git pull] habanalabs fixes for 5.13-rc2

On Sat, May 08, 2021 at 11:39:31AM +0300, Oded Gabbay wrote:
> Hi Greg,
>
> This pull request contains a number of important fixes for 5.13-rc2.
> Mainly fixes to support our new F/W with enhanced security features,
> but also additional bugs.
> See details in the tag message below.

Does this include the stuff in your previous pull request? Should I
drop that one from my queue or do both?

I will be waiting until after 5.13-rc1 before I can take any of these...

thanks,

greg k-h

2021-05-08 08:47:57

by Oded Gabbay

[permalink] [raw]
Subject: Re: [git pull] habanalabs fixes for 5.13-rc2

On Sat, May 8, 2021 at 11:42 AM Greg KH <[email protected]> wrote:
>
> On Sat, May 08, 2021 at 11:39:31AM +0300, Oded Gabbay wrote:
> > Hi Greg,
> >
> > This pull request contains a number of important fixes for 5.13-rc2.
> > Mainly fixes to support our new F/W with enhanced security features,
> > but also additional bugs.
> > See details in the tag message below.
>
> Does this include the stuff in your previous pull request? Should I
> drop that one from my queue or do both?
>
> I will be waiting until after 5.13-rc1 before I can take any of these...
>
> thanks,
>
> greg k-h

Yes, it includes that one. For some reason, lkml didn't show me that
the previous email was sent so I thought there was again a problem in
the mail server.
And therefore, I've sent this one again with 1 additional fix compared
to the previous one.
So you can drop the previous one.

Thanks,
Oded

2021-05-10 14:36:05

by Greg KH

[permalink] [raw]
Subject: Re: [git pull] habanalabs fixes for 5.13-rc2

On Sat, May 08, 2021 at 11:46:14AM +0300, Oded Gabbay wrote:
> On Sat, May 8, 2021 at 11:42 AM Greg KH <[email protected]> wrote:
> >
> > On Sat, May 08, 2021 at 11:39:31AM +0300, Oded Gabbay wrote:
> > > Hi Greg,
> > >
> > > This pull request contains a number of important fixes for 5.13-rc2.
> > > Mainly fixes to support our new F/W with enhanced security features,
> > > but also additional bugs.
> > > See details in the tag message below.
> >
> > Does this include the stuff in your previous pull request? Should I
> > drop that one from my queue or do both?
> >
> > I will be waiting until after 5.13-rc1 before I can take any of these...
> >
> > thanks,
> >
> > greg k-h
>
> Yes, it includes that one. For some reason, lkml didn't show me that
> the previous email was sent so I thought there was again a problem in
> the mail server.
> And therefore, I've sent this one again with 1 additional fix compared
> to the previous one.
> So you can drop the previous one.

Ok, now dropped the old one and pulled in this one, thanks!

greg k-h