2021-05-11 04:40:37

by Oleksij Rempel

Subject: [PATCH v3 6/7] ARM: imx6sx: remove Atheros AR8031 PHY fixup

If this patch breaks your system, enable AT803X_PHY driver and add a PHY
node to the board device tree:

phy-connection-type = "rgmii-txid"; (or rgmii-id)
ethernet-phy@X {
reg = <0xX>;

qca,clk-out-frequency = <125000000>;

vddio-supply = <&vddh>;

vddio: vddio-regulator {
regulator-name = "VDDIO";
regulator-min-microvolt = <1800000>;
regulator-max-microvolt = <1800000>;
};

vddh: vddh-regulator {
regulator-name = "VDDH";
};
};

Signed-off-by: Oleksij Rempel <[email protected]>
---
arch/arm/mach-imx/mach-imx6sx.c | 26 --------------------------
1 file changed, 26 deletions(-)

diff --git a/arch/arm/mach-imx/mach-imx6sx.c b/arch/arm/mach-imx/mach-imx6sx.c
index 781e2a94fdd7..e65ed5218f53 100644
--- a/arch/arm/mach-imx/mach-imx6sx.c
+++ b/arch/arm/mach-imx/mach-imx6sx.c
@@ -15,31 +15,6 @@
#include "common.h"
#include "cpuidle.h"

-static int ar8031_phy_fixup(struct phy_device *dev)
-{
- u16 val;
-
- /* Set RGMII IO voltage to 1.8V */
- phy_write(dev, 0x1d, 0x1f);
- phy_write(dev, 0x1e, 0x8);
-
- /* introduce tx clock delay */
- phy_write(dev, 0x1d, 0x5);
- val = phy_read(dev, 0x1e);
- val |= 0x0100;
- phy_write(dev, 0x1e, val);
-
- return 0;
-}
-
-#define PHY_ID_AR8031 0x004dd074
-static void __init imx6sx_enet_phy_init(void)
-{
- if (IS_BUILTIN(CONFIG_PHYLIB))
- phy_register_fixup_for_uid(PHY_ID_AR8031, 0xffffffff,
- ar8031_phy_fixup);
-}
-
static void __init imx6sx_enet_clk_sel(void)
{
struct regmap *gpr;
@@ -57,7 +32,6 @@ static void __init imx6sx_enet_clk_sel(void)

static inline void imx6sx_enet_init(void)
{
- imx6sx_enet_phy_init();
imx6sx_enet_clk_sel();
}

--
2.29.2

2021-05-11 12:54:00

by Andrew Lunn

Subject: Re: [PATCH v3 6/7] ARM: imx6sx: remove Atheros AR8031 PHY fixup

On Tue, May 11, 2021 at 06:37:34AM +0200, Oleksij Rempel wrote:
> If this patch breaks your system, enable AT803X_PHY driver and add a PHY
> node to the board device tree:
>
> phy-connection-type = "rgmii-txid"; (or rgmii-id)
> ethernet-phy@X {
> reg = <0xX>;
>
> qca,clk-out-frequency = <125000000>;
>
> vddio-supply = <&vddh>;
>
> vddio: vddio-regulator {
> regulator-name = "VDDIO";
> regulator-min-microvolt = <1800000>;
> regulator-max-microvolt = <1800000>;
> };
>
> vddh: vddh-regulator {
> regulator-name = "VDDH";
> };
> };
>
> Signed-off-by: Oleksij Rempel <[email protected]>

Reviewed-by: Andrew Lunn <[email protected]>

Andrew