2021-05-11 08:16:39

by David Hildenbrand

Subject: [PATCH resend v2 1/5] mm: make variable names for populate_vma_page_range() consistent

Let's make the variable names in the function declaration match the
variable names used in the definition.

Cc: Andrew Morton <[email protected]>
Cc: Michal Hocko <[email protected]>
Cc: Oscar Salvador <[email protected]>
Cc: Jason Gunthorpe <[email protected]>
Cc: Peter Xu <[email protected]>
Signed-off-by: David Hildenbrand <[email protected]>
---
mm/internal.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/internal.h b/mm/internal.h
index cb3c5e0a7799..bbf1c1274983 100644
--- a/mm/internal.h
+++ b/mm/internal.h
@@ -354,7 +354,7 @@ void __vma_unlink_list(struct mm_struct *mm, struct vm_area_struct *vma);

#ifdef CONFIG_MMU
extern long populate_vma_page_range(struct vm_area_struct *vma,
- unsigned long start, unsigned long end, int *nonblocking);
+ unsigned long start, unsigned long end, int *locked);
extern void munlock_vma_pages_range(struct vm_area_struct *vma,
unsigned long start, unsigned long end);
static inline void munlock_vma_pages_all(struct vm_area_struct *vma)
--
2.30.2

2021-05-11 09:55:26

by Oscar Salvador

Subject: Re: [PATCH resend v2 1/5] mm: make variable names for populate_vma_page_range() consistent

On Tue, May 11, 2021 at 10:15:30AM +0200, David Hildenbrand wrote:
> Let's make the variable names in the function declaration match the
> variable names used in the definition.
>
> Cc: Andrew Morton <[email protected]>
> Cc: Michal Hocko <[email protected]>
> Cc: Oscar Salvador <[email protected]>
> Cc: Jason Gunthorpe <[email protected]>
> Cc: Peter Xu <[email protected]>
> Signed-off-by: David Hildenbrand <[email protected]>

Reviewed-by: Oscar Salvador <[email protected]>

--
Oscar Salvador
SUSE L3

2021-05-11 09:59:32

by Oscar Salvador

Subject: Re: [PATCH resend v2 1/5] mm: make variable names for populate_vma_page_range() consistent

On Tue, May 11, 2021 at 11:54:25AM +0200, Oscar Salvador wrote:
> On Tue, May 11, 2021 at 10:15:30AM +0200, David Hildenbrand wrote:
> > Let's make the variable names in the function declaration match the
> > variable names used in the definition.
> >
> > Cc: Andrew Morton <[email protected]>
> > Cc: Michal Hocko <[email protected]>
> > Cc: Oscar Salvador <[email protected]>
> > Cc: Jason Gunthorpe <[email protected]>
> > Cc: Peter Xu <[email protected]>
> > Signed-off-by: David Hildenbrand <[email protected]>
>
> Reviewed-by: Oscar Salvador <[email protected]>

Fat fingers, s/sude/suse/

--
Oscar Salvador
SUSE L3