2021-04-09 15:36:20

by Andy Shevchenko

Subject: [PATCH v2 1/1] ata: Replace inclusion of kernel.h by bits.h in the header

ata.h uses BIT() macro, hence bits.h must be included. Otherwise
there is no need to have kernel.h included, I do not see any
direct users of it in ata.h. Hence replace inclusion of kernel.h.

Signed-off-by: Andy Shevchenko <[email protected]>
---
v2: replaced kernel.h by bits.h (lkp), tested allmod/yesconfig on x86_64 (Jens)
include/linux/ata.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/ata.h b/include/linux/ata.h
index 6e67aded28f8..1b44f40c7700 100644
--- a/include/linux/ata.h
+++ b/include/linux/ata.h
@@ -13,7 +13,7 @@
#ifndef __LINUX_ATA_H__
#define __LINUX_ATA_H__

-#include <linux/kernel.h>
+#include <linux/bits.h>
#include <linux/string.h>
#include <linux/types.h>
#include <asm/byteorder.h>
--
2.30.2

2021-05-17 19:09:47

by Andy Shevchenko

Subject: Re: [PATCH v2 1/1] ata: Replace inclusion of kernel.h by bits.h in the header

On Fri, Apr 09, 2021 at 06:34:56PM +0300, Andy Shevchenko wrote:
> ata.h uses BIT() macro, hence bits.h must be included. Otherwise
> there is no need to have kernel.h included, I do not see any
> direct users of it in ata.h. Hence replace inclusion of kernel.h.

Jens, can we now apply this one?

> Signed-off-by: Andy Shevchenko <[email protected]>
> ---
> v2: replaced kernel.h by bits.h (lkp), tested allmod/yesconfig on x86_64 (Jens)
> include/linux/ata.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/ata.h b/include/linux/ata.h
> index 6e67aded28f8..1b44f40c7700 100644
> --- a/include/linux/ata.h
> +++ b/include/linux/ata.h
> @@ -13,7 +13,7 @@
> #ifndef __LINUX_ATA_H__
> #define __LINUX_ATA_H__
>
> -#include <linux/kernel.h>
> +#include <linux/bits.h>
> #include <linux/string.h>
> #include <linux/types.h>
> #include <asm/byteorder.h>
> --
> 2.30.2
>

--
With Best Regards,
Andy Shevchenko

2021-05-18 19:21:42

by Jens Axboe

Subject: Re: [PATCH v2 1/1] ata: Replace inclusion of kernel.h by bits.h in the header

On 4/9/21 9:34 AM, Andy Shevchenko wrote:
> ata.h uses BIT() macro, hence bits.h must be included. Otherwise
> there is no need to have kernel.h included, I do not see any
> direct users of it in ata.h. Hence replace inclusion of kernel.h.

Applied, thanks.

--
Jens Axboe