2021-06-01 19:20:09

by Andrew Lunn

[permalink] [raw]
Subject: Re: [EXTERNAL] Re: [EXTERNAL] Re: [PATCH] net: phy: dp83867: perform soft reset and retain established link

On Tue, Jun 01, 2021 at 07:01:04PM +0000, Modi, Geet wrote:
> Hello Andrew,
>
>
>
> Please let me know if you have additional questions/clarifications to approve
> below change request.
>
>
>
> Regards,
> Geet
>
>
>
>
>
> From: Geet Modi <[email protected]>
> Date: Friday, May 28, 2021 at 10:10 AM
> To: Andrew Lunn <[email protected]>, "Bajjuri, Praneeth" <[email protected]>
> Cc: "David S . Miller" <[email protected]>, Jakub Kicinski <[email protected]>,
> "[email protected]" <[email protected]>,
> "[email protected]" <[email protected]>
> Subject: Re: [EXTERNAL] Re: [EXTERNAL] Re: [PATCH] net: phy: dp83867: perform
> soft reset and retain established link

So this all seems to boil down to, it does not matter if it is
acceptable or not, you are going to do it. So please just remove that
part of the comment. It has no value.

Andrew


2021-06-02 03:01:56

by Modi, Geet

[permalink] [raw]
Subject: Re: [EXTERNAL] Re: [EXTERNAL] Re: [EXTERNAL] Re: [PATCH] net: phy: dp83867: perform soft reset and retain established link

Praneeth,

Can you please help edit the comment and resubmit for approval ?

Regards,
Geet


On 6/1/21, 12:18 PM, "Andrew Lunn" <[email protected]> wrote:

On Tue, Jun 01, 2021 at 07:01:04PM +0000, Modi, Geet wrote:
> Hello Andrew,
>
>
>
> Please let me know if you have additional questions/clarifications to approve
> below change request.
>
>
>
> Regards,
> Geet
>
>
>
>
>
> From: Geet Modi <[email protected]>
> Date: Friday, May 28, 2021 at 10:10 AM
> To: Andrew Lunn <[email protected]>, "Bajjuri, Praneeth" <[email protected]>
> Cc: "David S . Miller" <[email protected]>, Jakub Kicinski <[email protected]>,
> "[email protected]" <[email protected]>,
> "[email protected]" <[email protected]>
> Subject: Re: [EXTERNAL] Re: [EXTERNAL] Re: [PATCH] net: phy: dp83867: perform
> soft reset and retain established link

So this all seems to boil down to, it does not matter if it is
acceptable or not, you are going to do it. So please just remove that
part of the comment. It has no value.

Andrew

2021-06-10 00:51:04

by Bajjuri, Praneeth

[permalink] [raw]
Subject: Re: [EXTERNAL] Re: [EXTERNAL] Re: [PATCH] net: phy: dp83867: perform soft reset and retain established link

Andrew,

On 6/1/2021 2:18 PM, Andrew Lunn wrote:
> On Tue, Jun 01, 2021 at 07:01:04PM +0000, Modi, Geet wrote:
>> Hello Andrew,
>>
>>
>>
>> Please let me know if you have additional questions/clarifications to approve
>> below change request.
>>
>>
>>
>> Regards,
>> Geet
>>
>>
>>
>>
>>
>> From: Geet Modi <[email protected]>
>> Date: Friday, May 28, 2021 at 10:10 AM
>> To: Andrew Lunn <[email protected]>, "Bajjuri, Praneeth" <[email protected]>
>> Cc: "David S . Miller" <[email protected]>, Jakub Kicinski <[email protected]>,
>> "[email protected]" <[email protected]>,
>> "[email protected]" <[email protected]>
>> Subject: Re: [EXTERNAL] Re: [EXTERNAL] Re: [PATCH] net: phy: dp83867: perform
>> soft reset and retain established link
>
> So this all seems to boil down to, it does not matter if it is
> acceptable or not, you are going to do it. So please just remove that
> part of the comment. It has no value.

Sent v2 addressing comment as per your suggestion.
Ref: https://lore.kernel.org/patchwork/patch/1444281/

Thanks
Praneeth

>
> Andrew
>