Use clk_prepare_enable()/clk_disable_unprepare() in preparation for switch
to Common Clock Framework.
Signed-off-by: Alexander Sverdlin <[email protected]>
---
drivers/input/keyboard/ep93xx_keypad.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/input/keyboard/ep93xx_keypad.c b/drivers/input/keyboard/ep93xx_keypad.c
index c8194333d612..e0e931e796fa 100644
--- a/drivers/input/keyboard/ep93xx_keypad.c
+++ b/drivers/input/keyboard/ep93xx_keypad.c
@@ -157,7 +157,7 @@ static int ep93xx_keypad_open(struct input_dev *pdev)
if (!keypad->enabled) {
ep93xx_keypad_config(keypad);
- clk_enable(keypad->clk);
+ clk_prepare_enable(keypad->clk);
keypad->enabled = true;
}
@@ -169,7 +169,7 @@ static void ep93xx_keypad_close(struct input_dev *pdev)
struct ep93xx_keypad *keypad = input_get_drvdata(pdev);
if (keypad->enabled) {
- clk_disable(keypad->clk);
+ clk_disable_unprepare(keypad->clk);
keypad->enabled = false;
}
}
--
2.32.0
Hi Alexander,
On Mon, Jun 14, 2021 at 01:30:37AM +0200, Alexander Sverdlin wrote:
> Use clk_prepare_enable()/clk_disable_unprepare() in preparation for switch
> to Common Clock Framework.
Can this be merged standalone?
>
> Signed-off-by: Alexander Sverdlin <[email protected]>
> ---
> drivers/input/keyboard/ep93xx_keypad.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/input/keyboard/ep93xx_keypad.c b/drivers/input/keyboard/ep93xx_keypad.c
> index c8194333d612..e0e931e796fa 100644
> --- a/drivers/input/keyboard/ep93xx_keypad.c
> +++ b/drivers/input/keyboard/ep93xx_keypad.c
> @@ -157,7 +157,7 @@ static int ep93xx_keypad_open(struct input_dev *pdev)
>
> if (!keypad->enabled) {
> ep93xx_keypad_config(keypad);
> - clk_enable(keypad->clk);
> + clk_prepare_enable(keypad->clk);
> keypad->enabled = true;
> }
>
> @@ -169,7 +169,7 @@ static void ep93xx_keypad_close(struct input_dev *pdev)
> struct ep93xx_keypad *keypad = input_get_drvdata(pdev);
>
> if (keypad->enabled) {
> - clk_disable(keypad->clk);
> + clk_disable_unprepare(keypad->clk);
> keypad->enabled = false;
While we are at it, I wonder about handling suspend/resume. I see that
we disable the clock even if keyboard is configured as a wakeup source.
Is it really capable of waking up the system when clock is off?
Thanks.
--
Dmitry
Hello Dmitry!
On Mon, 2021-06-14 at 14:55 -0700, Dmitry Torokhov wrote:
> > Use clk_prepare_enable()/clk_disable_unprepare() in preparation for switch
> > to Common Clock Framework.
>
> Can this be merged standalone?
In principle, yes, but I thought it would be easier if the patches
would go via the same path as CCF conversion.
> > Signed-off-by: Alexander Sverdlin <[email protected]>
> > ---
> > drivers/input/keyboard/ep93xx_keypad.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/input/keyboard/ep93xx_keypad.c b/drivers/input/keyboard/ep93xx_keypad.c
> > index c8194333d612..e0e931e796fa 100644
> > --- a/drivers/input/keyboard/ep93xx_keypad.c
> > +++ b/drivers/input/keyboard/ep93xx_keypad.c
> > @@ -157,7 +157,7 @@ static int ep93xx_keypad_open(struct input_dev *pdev)
> >
> > if (!keypad->enabled) {
> > ep93xx_keypad_config(keypad);
> > - clk_enable(keypad->clk);
> > + clk_prepare_enable(keypad->clk);
> > keypad->enabled = true;
> > }
> >
> > @@ -169,7 +169,7 @@ static void ep93xx_keypad_close(struct input_dev *pdev)
> > struct ep93xx_keypad *keypad = input_get_drvdata(pdev);
> >
> > if (keypad->enabled) {
> > - clk_disable(keypad->clk);
> > + clk_disable_unprepare(keypad->clk);
> > keypad->enabled = false;
>
> While we are at it, I wonder about handling suspend/resume. I see that
> we disable the clock even if keyboard is configured as a wakeup source.
> Is it really capable of waking up the system when clock is off?
That what "EP93xx User’s Guide" says:
26.2.4 Low Power Mode
The key scanning block also supports a low power wake-up mode. In this mode, a key press
generates a wake up interrupt. The key scan interrupt should be masked. Because the wake
up interrupt is asynchronous, and depends on external keypad lines which may have a large
capacitance value, glitches may occur on the interrupt when transitioning to low power mode.
After transitioning, all clocks to the key scanning circuitry can be shut down.
--
Alexander Sverdlin.
On Tue, Jun 15, 2021 at 09:46:51AM +0200, Alexander Sverdlin wrote:
> Hello Dmitry!
>
> On Mon, 2021-06-14 at 14:55 -0700, Dmitry Torokhov wrote:
> > > Use clk_prepare_enable()/clk_disable_unprepare() in preparation for switch
> > > to Common Clock Framework.
> >
> > Can this be merged standalone?
>
> In principle, yes, but I thought it would be easier if the patches
> would go via the same path as CCF conversion.
OK, in this case:
Acked-by: Dmitry Torokhov <[email protected]>
--
Dmitry
Hello Dmitry!
On 20/06/2021 05:23, Dmitry Torokhov wrote:
>>>> Use clk_prepare_enable()/clk_disable_unprepare() in preparation for switch
>>>> to Common Clock Framework.
>>>
>>> Can this be merged standalone?
>>
>> In principle, yes, but I thought it would be easier if the patches
>> would go via the same path as CCF conversion.
>
> OK, in this case:
>
> Acked-by: Dmitry Torokhov <[email protected]>
Seems that this doesn't work as we planned and two patches of the series
were already taken in by the respective maintainers.
Could you please apply this patch as well to your tree?
--
Alex.
Hello Dmitry,
On Sat, 2021-06-19 at 20:23 -0700, Dmitry Torokhov wrote:
> > On Mon, 2021-06-14 at 14:55 -0700, Dmitry Torokhov wrote:
> > > > Use clk_prepare_enable()/clk_disable_unprepare() in preparation for switch
> > > > to Common Clock Framework.
> > >
> > > Can this be merged standalone?
> >
> > In principle, yes, but I thought it would be easier if the patches
> > would go via the same path as CCF conversion.
>
> OK, in this case:
>
> Acked-by: Dmitry Torokhov <[email protected]>
our initial attempt to find a maintainer for the whole series
didn't work out. Would you take this single patch, please?
Three others were already taken into respective subsystems
and I'll ping the rest of maintainers individually...
--
Alexander Sverdlin.
Hi Alexander,
On Mon, Sep 13, 2021 at 11:29:14PM +0200, Alexander Sverdlin wrote:
> Hello Dmitry,
>
> On Sat, 2021-06-19 at 20:23 -0700, Dmitry Torokhov wrote:
> > > On Mon, 2021-06-14 at 14:55 -0700, Dmitry Torokhov wrote:
> > > > > Use clk_prepare_enable()/clk_disable_unprepare() in preparation for switch
> > > > > to Common Clock Framework.
> > > >
> > > > Can this be merged standalone?
> > >
> > > In principle, yes, but I thought it would be easier if the patches
> > > would go via the same path as CCF conversion.
> >
> > OK, in this case:
> >
> > Acked-by: Dmitry Torokhov <[email protected]>
>
> our initial attempt to find a maintainer for the whole series
> didn't work out. Would you take this single patch, please?
> Three others were already taken into respective subsystems
> and I'll ping the rest of maintainers individually...
It looks like I forgot to mention it, but I applied this patch and it
should be in mainline now. I also CCed you on a few patches to
ep93xx_keyboard driver and woudl appreciate if you looked them over as I
do not have the hardware.
Thanks.
--
Dmitry
Hello Dmitry,
On Mon, 2021-10-11 at 18:43 -0700, Dmitry Torokhov wrote:
> It looks like I forgot to mention it, but I applied this patch and it
> should be in mainline now. I also CCed you on a few patches to
> ep93xx_keyboard driver and woudl appreciate if you looked them over as I
> do not have the hardware.
thank you for the note!
I've acked 3 of the 4 patches you've sent, but will have comments on the
4th one...
--
Alexander Sverdlin.