2021-04-23 07:53:43

by Enric Balletbo i Serra

Subject: [PATCH] arm64: defconfig: Do not override the MTK_PMIC_WRAP symbol

Commit 'fbbe38309d56 ("arm64: defconfig: Allow mt8173-based boards to boot
from usb")' added the MTK_PMIC_WRAP config built-in. It needs to be
built-in in order to be able to boot from USB or the MMC without needing
a ramdisk, but that symbol was already defined as a module so now we are
getting the following warning:

arch/arm64/configs/defconfig:996:warning: override: reassigning to symbol MTK_PMIC_WRAP

Remove the MTK_PMIC_WRAP=m from the defconfig to remove the error.

Fixes: fbbe38309d56 ("arm64: defconfig: Allow mt8173-based boards to boot from usb")
Signed-off-by: Enric Balletbo i Serra <[email protected]>
---

arch/arm64/configs/defconfig | 1 -
1 file changed, 1 deletion(-)

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 08c6f769df9a..9907a431db0d 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -491,7 +491,6 @@ CONFIG_SPI_S3C64XX=y
CONFIG_SPI_SH_MSIOF=m
CONFIG_SPI_SUN6I=y
CONFIG_SPI_SPIDEV=m
-CONFIG_MTK_PMIC_WRAP=m
CONFIG_SPMI=y
CONFIG_PINCTRL_SINGLE=y
CONFIG_PINCTRL_MAX77620=y
--
2.30.2

2021-05-14 10:07:51

by Matthias Brugger

Subject: Re: [PATCH] arm64: defconfig: Do not override the MTK_PMIC_WRAP symbol

On 23/04/2021 09:52, Enric Balletbo i Serra wrote:
> Commit 'fbbe38309d56 ("arm64: defconfig: Allow mt8173-based boards to boot
> from usb")' added the MTK_PMIC_WRAP config built-in. It needs to be
> built-in in order to be able to boot from USB or the MMC without needing
> a ramdisk, but that symbol was already defined as a module so now we are
> getting the following warning:
>
> arch/arm64/configs/defconfig:996:warning: override: reassigning to symbol MTK_PMIC_WRAP
>
> Remove the MTK_PMIC_WRAP=m from the defconfig to remove the error.
>
> Fixes: fbbe38309d56 ("arm64: defconfig: Allow mt8173-based boards to boot from usb")
> Signed-off-by: Enric Balletbo i Serra <[email protected]>

Applied to v5.13-next/defconfig

Thanks!

> ---
>
> arch/arm64/configs/defconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index 08c6f769df9a..9907a431db0d 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -491,7 +491,6 @@ CONFIG_SPI_S3C64XX=y
> CONFIG_SPI_SH_MSIOF=m
> CONFIG_SPI_SUN6I=y
> CONFIG_SPI_SPIDEV=m
> -CONFIG_MTK_PMIC_WRAP=m
> CONFIG_SPMI=y
> CONFIG_PINCTRL_SINGLE=y
> CONFIG_PINCTRL_MAX77620=y
>

2021-06-11 21:51:48

by Petr Vorel

Subject: Re: [PATCH] arm64: defconfig: Do not override the MTK_PMIC_WRAP symbol

Hi all,

> On 23/04/2021 09:52, Enric Balletbo i Serra wrote:
> > Commit 'fbbe38309d56 ("arm64: defconfig: Allow mt8173-based boards to boot
> > from usb")' added the MTK_PMIC_WRAP config built-in. It needs to be
> > built-in in order to be able to boot from USB or the MMC without needing
> > a ramdisk, but that symbol was already defined as a module so now we are
> > getting the following warning:

> > arch/arm64/configs/defconfig:996:warning: override: reassigning to symbol MTK_PMIC_WRAP

> > Remove the MTK_PMIC_WRAP=m from the defconfig to remove the error.

> > Fixes: fbbe38309d56 ("arm64: defconfig: Allow mt8173-based boards to boot from usb")
> > Signed-off-by: Enric Balletbo i Serra <[email protected]>

> Applied to v5.13-next/defconfig
I'm sorry, please ignore my useless Reviewed-by: tag.

I was searching in arm64 git [1] and overlooked the date.
I see it was merged into Matthias' git tree [2] month ago.

Kind regards,
Petr

[1] https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git
[2] https://git.kernel.org/pub/scm/linux/kernel/git/matthias.bgg/linux.git/commit/?h=v5.13-next-defconfig&id=f0e70d4946332c681ceaba940652f30c7c33473d