2021-06-15 11:54:10

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH v4 1/3] tty: serial: Add UART driver for Cortina-Access platform

On Sun, May 09, 2021 at 11:45:16AM -0700, Alex Nemirovsky wrote:
> From: Jason Li <[email protected]>
>
> This driver supports Cortina Access UART IP integrated
> in most all CAXXXX line of SoCs. Earlycom is also supported
>
> Signed-off-by: Jason Li <[email protected]>
> ---

I can't take this without the DT maintainers acking the DT changes.

So can you resend this so that they can notice that it requires their
review?

thanks,

greg k-h


2021-06-15 13:36:19

by Alex Nemirovsky

[permalink] [raw]
Subject: Re: [PATCH v4 1/3] tty: serial: Add UART driver for Cortina-Access platform

The DT maintainers were CC’ed for the DT related files. However, I suspect they won’t
ACK it until you ACK the actual serial port driver.

> On Jun 15, 2021, at 4:52 AM, Greg Kroah-Hartman <[email protected]> wrote:
>
> On Sun, May 09, 2021 at 11:45:16AM -0700, Alex Nemirovsky wrote:
>> From: Jason Li <[email protected]>
>>
>> This driver supports Cortina Access UART IP integrated
>> in most all CAXXXX line of SoCs. Earlycom is also supported
>>
>> Signed-off-by: Jason Li <[email protected]>
>> ---
>
> I can't take this without the DT maintainers acking the DT changes.
>
> So can you resend this so that they can notice that it requires their
> review?
>
> thanks,
>
> greg k-h

2021-06-15 14:17:42

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH v4 1/3] tty: serial: Add UART driver for Cortina-Access platform

On Tue, Jun 15, 2021 at 01:32:51PM +0000, Alex Nemirovsky wrote:
> The DT maintainers were CC’ed for the DT related files. However, I suspect they won’t
> ACK it until you ACK the actual serial port driver.

It goes the other way around :)

2021-06-15 14:35:15

by Alex Nemirovsky

[permalink] [raw]
Subject: Re: [PATCH v4 1/3] tty: serial: Add UART driver for Cortina-Access platform

Does the serial driver portion in the first patch, require any more changes from your point of view
as the serial driver maintainer? If there are no issues with the driver itself, we can engage with the DT team to figure out why they have not
ACK or provided any feedback on the DT portion. Are you good with the content of the serial driver itself minus the lack of ACK from the DT team?

> On Jun 15, 2021, at 7:13 AM, Greg Kroah-Hartman <[email protected]> wrote:
>
> On Tue, Jun 15, 2021 at 01:32:51PM +0000, Alex Nemirovsky wrote:
>> The DT maintainers were CC’ed for the DT related files. However, I suspect they won’t
>> ACK it until you ACK the actual serial port driver.
>
> It goes the other way around :)

2021-06-15 15:41:43

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH v4 1/3] tty: serial: Add UART driver for Cortina-Access platform

A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

A: No.
Q: Should I include quotations after my reply?

http://daringfireball.net/2007/07/on_top

On Tue, Jun 15, 2021 at 02:33:57PM +0000, Alex Nemirovsky wrote:
> Does the serial driver portion in the first patch, require any more changes from your point of view
> as the serial driver maintainer? If there are no issues with the driver itself, we can engage with the DT team to figure out why they have not
> ACK or provided any feedback on the DT portion. Are you good with the content of the serial driver itself minus the lack of ACK from the DT team?

I was waiting for the DT review before I looked at the serial driver
again.

thanks,

greg k-h

2021-06-15 16:05:01

by Alex Nemirovsky

[permalink] [raw]
Subject: Re: [PATCH v4 1/3] tty: serial: Add UART driver for Cortina-Access platform



> On Jun 15, 2021, at 8:40 AM, Greg Kroah-Hartman <[email protected]> wrote:
>
> A: http://en.wikipedia.org/wiki/Top_post
> Q: Were do I find info about this thing called top-posting?
> A: Because it messes up the order in which people normally read text.
> Q: Why is top-posting such a bad thing?
> A: Top-posting.
> Q: What is the most annoying thing in e-mail?
>
> A: No.
> Q: Should I include quotations after my reply?
>
> http://daringfireball.net/2007/07/on_top
>
> On Tue, Jun 15, 2021 at 02:33:57PM +0000, Alex Nemirovsky wrote:
>> Does the serial driver portion in the first patch, require any more changes from your point of view
>> as the serial driver maintainer? If there are no issues with the driver itself, we can engage with the DT team to figure out why they have not
>> ACK or provided any feedback on the DT portion. Are you good with the content of the serial driver itself minus the lack of ACK from the DT team?
>
> I was waiting for the DT review before I looked at the serial driver
> again.
>
> thanks,
>
> greg k-h

Seems like we might be in a catch-22 situation here. This patch series has been in review around 6 months no and I have yet to see any feedback from the DT team.
Do you ever reach out to them to try to get closer? If you have had luck, perhaps you can send a quick email to them to get this driver off your plate. I’m sure you
would rather have this resolved on off your queue so you can have more time for other more important matters.