2021-06-11 06:55:16

by Austin Kim

Subject: [PATCH] dmaengine: sf-pdma: apply proper spinlock flags in sf_pdma_prep_dma_memcpy()

From: Austin Kim <[email protected]>

The second parameter of spinlock_irq[save/restore] function is flags,
which is the last input parameter of sf_pdma_prep_dma_memcpy().

So declare local variable 'iflags' to be used as the second parameter of
spinlock_irq[save/restore] function.

Signed-off-by: Austin Kim <[email protected]>
---
drivers/dma/sf-pdma/sf-pdma.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/dma/sf-pdma/sf-pdma.c b/drivers/dma/sf-pdma/sf-pdma.c
index c4c4e8575764..f12606aeff87 100644
--- a/drivers/dma/sf-pdma/sf-pdma.c
+++ b/drivers/dma/sf-pdma/sf-pdma.c
@@ -94,6 +94,7 @@ sf_pdma_prep_dma_memcpy(struct dma_chan *dchan, dma_addr_t dest, dma_addr_t src,
{
struct sf_pdma_chan *chan = to_sf_pdma_chan(dchan);
struct sf_pdma_desc *desc;
+ unsigned long iflags;

if (chan && (!len || !dest || !src)) {
dev_err(chan->pdma->dma_dev.dev,
@@ -109,10 +110,10 @@ sf_pdma_prep_dma_memcpy(struct dma_chan *dchan, dma_addr_t dest, dma_addr_t src,
desc->dirn = DMA_MEM_TO_MEM;
desc->async_tx = vchan_tx_prep(&chan->vchan, &desc->vdesc, flags);

- spin_lock_irqsave(&chan->vchan.lock, flags);
+ spin_lock_irqsave(&chan->vchan.lock, iflags);
chan->desc = desc;
sf_pdma_fill_desc(desc, dest, src, len);
- spin_unlock_irqrestore(&chan->vchan.lock, flags);
+ spin_unlock_irqrestore(&chan->vchan.lock, iflags);

return desc->async_tx;
}
--
2.20.1

2021-06-16 10:41:31

by Vinod Koul

Subject: Re: [PATCH] dmaengine: sf-pdma: apply proper spinlock flags in sf_pdma_prep_dma_memcpy()

On 11-06-21, 07:53, Austin Kim wrote:
> From: Austin Kim <[email protected]>
>
> The second parameter of spinlock_irq[save/restore] function is flags,
> which is the last input parameter of sf_pdma_prep_dma_memcpy().
>
> So declare local variable 'iflags' to be used as the second parameter of
> spinlock_irq[save/restore] function.

Applied, thanks

--
~Vinod

2021-06-16 11:01:02

by Austin Kim

Subject: Re: [PATCH] dmaengine: sf-pdma: apply proper spinlock flags in sf_pdma_prep_dma_memcpy()

2021년 6월 16일 (수) 오후 7:40, Vinod Koul <[email protected]>님이 작성:
>
> On 11-06-21, 07:53, Austin Kim wrote:
> > From: Austin Kim <[email protected]>
> >
> > The second parameter of spinlock_irq[save/restore] function is flags,
> > which is the last input parameter of sf_pdma_prep_dma_memcpy().
> >
> > So declare local variable 'iflags' to be used as the second parameter of
> > spinlock_irq[save/restore] function.
>
> Applied, thanks

Great, thanks!

>
> --
> ~Vinod