2021-06-16 13:41:27

by Colin King

[permalink] [raw]
Subject: [PATCH] mlxsw: spectrum_router: remove redundant continue statement

From: Colin Ian King <[email protected]>

The continue statement at the end of a for-loop has no effect,
remove it.

Addresses-Coverity: ("Continue has no effect")
Signed-off-by: Colin Ian King <[email protected]>
---
drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c
index bc47ed766878..7e221ef01437 100644
--- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c
+++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c
@@ -5407,7 +5407,6 @@ mlxsw_sp_rt6_nexthop(struct mlxsw_sp_nexthop_group *nh_grp,
ipv6_addr_equal((const struct in6_addr *) &nh->gw_addr,
&rt->fib6_nh->fib_nh_gw6))
return nh;
- continue;
}

return NULL;
--
2.31.1


2021-06-16 19:10:48

by Ido Schimmel

[permalink] [raw]
Subject: Re: [PATCH] mlxsw: spectrum_router: remove redundant continue statement

On Wed, Jun 16, 2021 at 02:02:58PM +0100, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> The continue statement at the end of a for-loop has no effect,
> remove it.
>
> Addresses-Coverity: ("Continue has no effect")
> Signed-off-by: Colin Ian King <[email protected]>

For net-next:

Reviewed-by: Ido Schimmel <[email protected]>

Thanks

2021-06-17 02:03:44

by patchwork-bot+netdevbpf

[permalink] [raw]
Subject: Re: [PATCH] mlxsw: spectrum_router: remove redundant continue statement

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Wed, 16 Jun 2021 14:02:58 +0100 you wrote:
> From: Colin Ian King <[email protected]>
>
> The continue statement at the end of a for-loop has no effect,
> remove it.
>
> Addresses-Coverity: ("Continue has no effect")
> Signed-off-by: Colin Ian King <[email protected]>
>
> [...]

Here is the summary with links:
- mlxsw: spectrum_router: remove redundant continue statement
https://git.kernel.org/netdev/net-next/c/fb0a1dacf2be

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html