2021-06-16 20:25:15

by Andrea Righi

Subject: [PATCH] selftests: net: use bash to run udpgro_fwd test case

udpgro_fwd.sh contains many bash specific operators ("[[", "local -r"),
but it's using /bin/sh; in some distro /bin/sh is mapped to /bin/dash,
that doesn't support such operators.

Force the test to use /bin/bash explicitly and prevent false positive
test failures.

Signed-off-by: Andrea Righi <[email protected]>
---
tools/testing/selftests/net/udpgro_fwd.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/net/udpgro_fwd.sh b/tools/testing/selftests/net/udpgro_fwd.sh
index a8fa64136282..7f26591f236b 100755
--- a/tools/testing/selftests/net/udpgro_fwd.sh
+++ b/tools/testing/selftests/net/udpgro_fwd.sh
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/bash
# SPDX-License-Identifier: GPL-2.0

readonly BASE="ns-$(mktemp -u XXXXXX)"
--
2.31.1

2021-06-17 02:11:41

by patchwork-bot+netdevbpf

Subject: Re: [PATCH] selftests: net: use bash to run udpgro_fwd test case

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Wed, 16 Jun 2021 16:57:27 +0200 you wrote:
> udpgro_fwd.sh contains many bash specific operators ("[[", "local -r"),
> but it's using /bin/sh; in some distro /bin/sh is mapped to /bin/dash,
> that doesn't support such operators.
>
> Force the test to use /bin/bash explicitly and prevent false positive
> test failures.
>
> [...]

Here is the summary with links:
- selftests: net: use bash to run udpgro_fwd test case
https://git.kernel.org/netdev/net/c/1b29df0e2e80

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html