Hi all,
After merging the printk tree, today's linux-next build (mips allnoconfig)
failed like this:
arch/mips/kernel/genex.o: In function `handle_mcheck_int':
(.text+0x190c): undefined reference to `printk'
arch/mips/kernel/genex.o: In function `handle_reserved_int':
(.text+0x1c8c): undefined reference to `printk'
Caused by commit
337015573718 ("printk: Userspace format indexing support")
--
Cheers,
Stephen Rothwell
On Tue, 20 Jul 2021 at 13:13, Stephen Rothwell <[email protected]> wrote:
>
> Hi all,
>
> After merging the printk tree, today's linux-next build (mips allnoconfig)
> failed like this:
>
> arch/mips/kernel/genex.o: In function `handle_mcheck_int':
> (.text+0x190c): undefined reference to `printk'
> arch/mips/kernel/genex.o: In function `handle_reserved_int':
> (.text+0x1c8c): undefined reference to `printk'
>
> Caused by commit
>
> 337015573718 ("printk: Userspace format indexing support")
Following MIPS builds failed at our end due the reported problem.
- build/gcc-10-allnoconfig
- build/gcc-10-ar7_defconfig
- build/gcc-10-ath79_defconfig
- build/gcc-10-bcm47xx_defconfig
- build/gcc-10-bcm63xx_defconfig
- build/gcc-10-cavium_octeon_defconfig
- build/gcc-10-defconfig
- build/gcc-10-e55_defconfig
- build/gcc-10-malta_defconfig
- build/gcc-10-nlm_xlp_defconfig
- build/gcc-10-rt305x_defconfig
>
> --
> Cheers,
> Stephen Rothwell
- Naresh
Hey folks,
Naresh Kamboju writes:
>On Tue, 20 Jul 2021 at 13:13, Stephen Rothwell <[email protected]> wrote:
>>
>> Hi all,
>>
>> After merging the printk tree, today's linux-next build (mips allnoconfig)
>> failed like this:
>>
>> arch/mips/kernel/genex.o: In function `handle_mcheck_int':
>> (.text+0x190c): undefined reference to `printk'
>> arch/mips/kernel/genex.o: In function `handle_reserved_int':
>> (.text+0x1c8c): undefined reference to `printk'
>>
>> Caused by commit
>>
>> 337015573718 ("printk: Userspace format indexing support")
>
>Following MIPS builds failed at our end due the reported problem.
Thanks: missed this as I made sure to change all .S files to use _printk, but
this is in a .h file included in a .S file.
Here's what's needed. :-)
diff --git arch/mips/include/asm/asm.h arch/mips/include/asm/asm.h
index ea4b62ece336..2f8ce94ebaaf 100644
--- arch/mips/include/asm/asm.h
+++ arch/mips/include/asm/asm.h
@@ -114,7 +114,7 @@ symbol = value
.set push; \
.set reorder; \
PTR_LA a0, 8f; \
- jal printk; \
+ jal _printk; \
.set pop; \
TEXT(string)
#else
On Tue 2021-07-20 13:28:45, Chris Down wrote:
> Hey folks,
>
> Naresh Kamboju writes:
> > On Tue, 20 Jul 2021 at 13:13, Stephen Rothwell <[email protected]> wrote:
> > >
> > > Hi all,
> > >
> > > After merging the printk tree, today's linux-next build (mips allnoconfig)
> > > failed like this:
> > >
> > > arch/mips/kernel/genex.o: In function `handle_mcheck_int':
> > > (.text+0x190c): undefined reference to `printk'
> > > arch/mips/kernel/genex.o: In function `handle_reserved_int':
> > > (.text+0x1c8c): undefined reference to `printk'
> > >
> > > Caused by commit
> > >
> > > 337015573718 ("printk: Userspace format indexing support")
> >
> > Following MIPS builds failed at our end due the reported problem.
>
> Thanks: missed this as I made sure to change all .S files to use _printk,
> but this is in a .h file included in a .S file.
>
> Here's what's needed. :-)
>
> diff --git arch/mips/include/asm/asm.h arch/mips/include/asm/asm.h
> index ea4b62ece336..2f8ce94ebaaf 100644
> --- arch/mips/include/asm/asm.h
> +++ arch/mips/include/asm/asm.h
> @@ -114,7 +114,7 @@ symbol = value
> .set push; \
> .set reorder; \
> PTR_LA a0, 8f; \
> - jal printk; \
> + jal _printk; \
> .set pop; \
> TEXT(string)
> #else
Chris, could you please send it as a proper patch?
Best Regards,
Petr
Petr Mladek writes:
>Chris, could you please send it as a proper patch?
Sure thing -- just to confirm, resend the whole series to you with these fixes
squashed in, right? :-)
On Wed 2021-07-21 12:22:18, Chris Down wrote:
> Petr Mladek writes:
> > Chris, could you please send it as a proper patch?
>
> Sure thing -- just to confirm, resend the whole series to you with these
> fixes squashed in, right? :-)
Good question. I would prefer to avoid the rebase. Please, send
it as a followup patch.
Best Regards,
Petr
Hi all,
On Tue, 20 Jul 2021 17:43:00 +1000 Stephen Rothwell <[email protected]> wrote:
>
> Hi all,
>
> After merging the printk tree, today's linux-next build (mips allnoconfig)
> failed like this:
>
> arch/mips/kernel/genex.o: In function `handle_mcheck_int':
> (.text+0x190c): undefined reference to `printk'
> arch/mips/kernel/genex.o: In function `handle_reserved_int':
> (.text+0x1c8c): undefined reference to `printk'
>
> Caused by commit
>
> 337015573718 ("printk: Userspace format indexing support")
I am still getting these failures.
--
Cheers,
Stephen Rothwell
On Fri 2021-07-23 09:01:36, Stephen Rothwell wrote:
> Hi all,
>
> On Tue, 20 Jul 2021 17:43:00 +1000 Stephen Rothwell <[email protected]> wrote:
> >
> > Hi all,
> >
> > After merging the printk tree, today's linux-next build (mips allnoconfig)
> > failed like this:
> >
> > arch/mips/kernel/genex.o: In function `handle_mcheck_int':
> > (.text+0x190c): undefined reference to `printk'
> > arch/mips/kernel/genex.o: In function `handle_reserved_int':
> > (.text+0x1c8c): undefined reference to `printk'
> >
> > Caused by commit
> >
> > 337015573718 ("printk: Userspace format indexing support")
>
> I am still getting these failures.
I have just pushed the proposed fix into printk/linux.git,
branch for-5.15-printk-index.
I am sorry for the delay. I waited for a patch with reasonable commit
message from Chris. I did it myself after all.
Thanks for the report.
Best Regards,
Petr
Hey folks,
Petr Mladek writes:
>I am sorry for the delay. I waited for a patch with reasonable commit
>message from Chris. I did it myself after all.
My sincere apologies for the delay. I had it in my calendar to do yesterday
afternoon, but ended up with no time left :-(
Thanks Petr for pushing them, and sorry for the trouble caused.